Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using process substitution #12244

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Stop using process substitution #12244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions prow/cmd/phaino/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ whereas we only see the imperfect physical appearances of those idea.

He linkens this in his [Allegory of the Cave] to someone living in a cave
who can only see the shadows projected on the wall
from objects passing in front of a fire.
from objects passing in front of a fire.

[Phaino] is act of making those imperfect shadows appear.

Expand All @@ -20,7 +20,8 @@ Usage:
# Use a job from deck
bazel run //prow/cmd/phaino -- $URL # or /path/to/prowjob.yaml
# Use mkpj to create the job
bazel run //prow/cmd/phaino -- <(bazel run //prow/cmd/mkpj -- --config-path=/your/config --job=foo)
bazel run //prow/cmd/mkpj -- --config-path=/your/config --job=foo > /tmp/foo
bazel run //prow/cmd/phaino -- /tmp/foo
```

### Common options
Expand Down Expand Up @@ -48,9 +49,15 @@ A `mkpj` example:

* Use `mkpj` to create the job and pipe this to `phaino`
- For prow.k8s.io jobs use `//config:mkpj`
* `bazel run //prow/cmd/phaino -- <(bazel run //config:mkpj -- --job=pull-test-infra-bazel)`
```
bazel run //config:mkpj -- --job=pull-test-infra-bazel > /tmp/foo
bazel run //prow/cmd/phaino -- /tmp/foo
```
- Other deployments will need to clone that rule and/or pass in extra flags:
* `bazel run //prow/cmd/phaino -- <(bazel run //prow/cmd/mkpj -- --config-path=/my/config.yaml --job=my-job)`
```
bazel run //prow/cmd/mkpj -- --config-path=/my/config.yaml --job=my-job
bazel run //prow/cmd/phaino -- /tmp/foo
```

If you cannot use bazel (or do not want to), use `go get -u k8s.io/test-infra/prow/cmd/phaino`.

Expand Down