Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare some trusted service accounts #15937

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Declare some trusted service accounts #15937

merged 1 commit into from
Feb 12, 2020

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Jan 17, 2020

ref #15806

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/prow Issues or PRs related to prow area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 17, 2020
@fejta fejta requested review from michelle192837 and removed request for krzyzacy January 18, 2020 00:23
@fejta
Copy link
Contributor Author

fejta commented Feb 12, 2020

Ping!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4285524 into kubernetes:master Feb 12, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 12, 2020
@fejta fejta deleted the serve branch February 12, 2020 18:49
@fejta
Copy link
Contributor Author

fejta commented Feb 12, 2020 

fejta@fejta3:~/src/gh/test-infra$ ./experiment/workload-identity/bind-service-accounts.sh k8s-prow us-central1-f prow test-pods resultstore [email protected]
+ gcloud iam service-accounts add-iam-policy-binding --project=k8s-prow --role=roles/iam.workloadIdentityUser '--member=serviceAccount:k8s-prow.svc.id.goog[test-pods/resultstore]' [email protected]
Updated IAM policy for serviceAccount [[email protected]].
Sleeping 2m to allow credentials to propagate..

@fejta
Copy link
Contributor Author

fejta commented Feb 12, 2020

And the others too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelle192837 michelle192837 michelle192837 approved these changes

@Katharine Katharine Awaiting requested review from Katharine

Assignees

@michelle192837 michelle192837

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
3 participants
@fejta @k8s-ci-robot @michelle192837