Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workload identity to push prow and boskos #16261

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Feb 12, 2020

Switch from using a secret file to a service account

ref #15806

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2020
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 12, 2020
@fejta fejta reopened this Feb 12, 2020
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Feb 12, 2020
@kubernetes kubernetes deleted a comment from k8s-ci-robot Feb 12, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2020
@fejta fejta changed the title Downgrade boskos Use workload identity to push prow and boskos Feb 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta fejta removed the request for review from alvaroaleman February 12, 2020 23:45
@fejta
Copy link
Contributor Author

fejta commented Feb 13, 2020

This appears to be passing tests now?

@Katharine
Copy link
Member

/lgtm
/hold
feel free to unhold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2020
@fejta
Copy link
Contributor Author

fejta commented Feb 13, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit ad6ed45 into kubernetes:master Feb 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 13, 2020
@k8s-ci-robot
Copy link
Contributor

@fejta: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

Switch from using a secret file to a service account

ref #15806

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta fejta deleted the ri branch February 13, 2020 19:24
@fejta
Copy link
Contributor Author

fejta commented Feb 13, 2020

@fejta
Copy link
Contributor Author

fejta commented Feb 13, 2020

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants