Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate image-pushing jobs to use workload identity #16396

Merged
merged 13 commits into from
Feb 20, 2020

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Feb 20, 2020

/assign @michelle192837 @justaugustus @Katharine

ref #15806

Following

serviceAccountName: deployer # TODO(fejta): should be pusher
containers:
- image: gcr.io/k8s-testimages/image-builder:v20200213-0032cdb

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 20, 2020
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2657fcc into kubernetes:master Feb 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

@fejta: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key k8s-staging-apiserver-network-proxy.yaml using file config/jobs/image-pushing/k8s-staging-apiserver-network-proxy.yaml
  • key k8s-staging-apisnoop.yaml using file config/jobs/image-pushing/k8s-staging-apisnoop.yaml
  • key k8s-staging-artifact-promoter.yaml using file config/jobs/image-pushing/k8s-staging-artifact-promoter.yaml
  • key k8s-staging-capi-openstack.yaml using file config/jobs/image-pushing/k8s-staging-capi-openstack.yaml
  • key k8s-staging-cluster-api.yaml using file config/jobs/image-pushing/k8s-staging-cluster-api.yaml
  • key k8s-staging-descheduler.yaml using file config/jobs/image-pushing/k8s-staging-descheduler.yaml
  • key k8s-staging-e2e-test-images.yaml using file config/jobs/image-pushing/k8s-staging-e2e-test-images.yaml
  • key k8s-staging-external-dns.yaml using file config/jobs/image-pushing/k8s-staging-external-dns.yaml
  • key k8s-staging-kops.yaml using file config/jobs/image-pushing/k8s-staging-kops.yaml
  • key k8s-staging-provider-azure.yaml using file config/jobs/image-pushing/k8s-staging-provider-azure.yaml
  • key k8s-staging-release-test.yaml using file config/jobs/image-pushing/k8s-staging-release-test.yaml
  • key k8s-staging-service-apis.yaml using file config/jobs/image-pushing/k8s-staging-service-apis.yaml

In response to this:

/assign @michelle192837 @justaugustus @Katharine

ref #15806

Following

serviceAccountName: deployer # TODO(fejta): should be pusher
containers:
- image: gcr.io/k8s-testimages/image-builder:v20200213-0032cdb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta fejta deleted the oncall branch February 20, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants