Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tide use workload identity for GCP auth #16465

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Feb 25, 2020

/assign @cjwagner @michelle192837

ref #15806 #16464

$ gsutil iam get gs://k8s-prow
{
...
    {
      "members": [
        "serviceAccount:[email protected]",
        "serviceAccount:[email protected]"
      ],
      "role": "roles/storage.objectAdmin"
    }
...
}
$ workload-identity/bind-service-accounts.sh k8s-prow us-central1-f prow default tide [email protected]
ALREADY MEMBER: serviceAccount:k8s-prow.svc.id.goog[default/tide] has roles/iam.workloadIdentityUser for [email protected].
+++ kubectl run --rm=true -i --generator=run-pod/v1 --context=gke_k8s-prow_us-central1-f_prow --namespace=default --serviceaccount=tide --image=google/cloud-sdk:slim workload-identity-test-17
DONE: --context=gke_k8s-prow_us-central1-f_prow --namespace=default serviceaccounts/tide acts as [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 25, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cc92bd2 into kubernetes:master Feb 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 25, 2020
@fejta fejta deleted the tide branch February 25, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants