Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make critical jobs Guaranteed Pod QOS for ci-kubernetes-build-fast #18619

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Make critical jobs Guaranteed Pod QOS for ci-kubernetes-build-fast #18619

merged 1 commit into from
Aug 3, 2020

Conversation

helenfeng737
Copy link
Contributor

@helenfeng737 helenfeng737 commented Aug 3, 2020 •
edited
Loading

Set pod resource and cpu as @spiffxp suggested in the issue: #18578

Fixes: #18578
Part of: #18530

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ZhiFeng1993. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 3, 2020
@helenfeng737
Copy link
Contributor Author

@kubernetes/ci-signal

hasheddan
hasheddan reviewed Aug 3, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2020
@BenTheElder
Copy link
Member

#18620 (comment)

spiffxp
spiffxp approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
FYI @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp, ZhiFeng1993

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit b48875e into kubernetes:master Aug 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 3, 2020
@k8s-ci-robot
Copy link
Contributor

@ZhiFeng1993: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kubernetes-builds.yaml using file config/jobs/kubernetes/sig-release/kubernetes-builds.yaml

In response to this:

Set pod resource and cpu as @spiffxp suggested in the issue: #18578

Fixes: #18578

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member

@ZhiFeng1993 -- Thanks!

@tpepper tpepper mentioned this pull request Aug 3, 2020
Closed
36 tasks
@helenfeng737 helenfeng737 mentioned this pull request Aug 10, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan left review comments

@spiffxp spiffxp spiffxp approved these changes

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Make critical jobs Guaranteed Pod QOS: ci-kubernetes-build-fast
6 participants
@helenfeng737 @k8s-ci-robot @BenTheElder @justaugustus @spiffxp @hasheddan