Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

critical jobs Guaranteed Pod QOS: periodic-kubernetes-bazel-build #18629

Merged
merged 1 commit into from
Aug 3, 2020
Merged

critical jobs Guaranteed Pod QOS: periodic-kubernetes-bazel-build #18629

merged 1 commit into from
Aug 3, 2020

Conversation

tpepper
Copy link
Member

@tpepper tpepper commented Aug 3, 2020 •
edited
Loading

Adding basic resource request and limit for
periodic-kubernetes-bazel-build, which is in the
sig-release-master-blocking dashboard.

Signed-off-by: Tim Pepper [email protected]

/cc @kubernetes/ci-signal

Fixes: #18581

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 3, 2020
critical jobs Guaranteed Pod QOS: periodic-kubernetes-bazel-build
27b5842 
Adding basic resource request and limit for
periodic-kubernetes-bazel-build, which is in the
sig-release-master-blocking dashboard.

Signed-off-by: Tim Pepper <[email protected]>
hasheddan
hasheddan approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2020
@tpepper tpepper mentioned this pull request Aug 3, 2020
Closed
36 tasks
spiffxp
spiffxp approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit c7a67d8 into kubernetes:master Aug 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 3, 2020
@k8s-ci-robot
Copy link
Contributor

@tpepper: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key 1.16.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.16.yaml
  • key 1.17.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.17.yaml
  • key 1.18.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml
  • key 1.19.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.19.yaml
  • key bazel-build-test.yaml using file config/jobs/kubernetes/sig-testing/bazel-build-test.yaml

In response to this:

Adding basic resource request and limit for
periodic-kubernetes-bazel-build, which is in the
sig-release-master-blocking dashboard.

Signed-off-by: Tim Pepper [email protected]

/cc @kubernetes/ci-signal

Fixes: #18581

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam ameukam mentioned this pull request Aug 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@hasheddan hasheddan hasheddan approved these changes

Assignees

@spiffxp spiffxp

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Make critical jobs Guaranteed Pod QOS: periodic-kubernetes-bazel-build
4 participants
@tpepper @k8s-ci-robot @spiffxp @hasheddan