Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pull-kubernetes-bazel-build to k8s-infra-prow-build #19855

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Migrate pull-kubernetes-bazel-build to k8s-infra-prow-build #19855

merged 1 commit into from
Nov 23, 2020

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Nov 5, 2020

Part of #19073
Ref: #18550

Signed-off-by: Arnaud Meukam [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 5, 2020
@ameukam
Copy link
Member Author

ameukam commented Nov 5, 2020

1.16 job variant was ignored : #19850
/assign @spiffxp
cc @kubernetes/ci-signal

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2020
@justaugustus
Copy link
Member

/lgtm but hold for Aaron's review.

spiffxp
spiffxp approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold
I want us to confirm that ci-kubernetes-bazel-build is fully functional over there before releasing the hold to move forward with presubmits

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2020
@spiffxp
Copy link
Member

spiffxp commented Nov 5, 2020

Most recent run of the ci-kubernetes-build-canary is still failing: https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-build-canary/1324380000262033408

@spiffxp
Copy link
Member

spiffxp commented Nov 20, 2020 •
edited
Loading

I want us to confirm that ci-kubernetes-bazel-build is fully functional over there before releasing the hold to move forward with presubmits

#19483 (comment) we are writing artifacts, I would be willing to move forward with this

However, I'm not going to remove the /hold right now because I can't commit to babysitting these jobs / reverting over the weekend. If someone else wants to, please go for it.

Otherwise I will move on this Monday before test freeze

@ameukam
Copy link
Member Author

ameukam commented Nov 20, 2020

Otherwise I will move on this Monday before test freeze

+1 for remove the /hold Monday.

@spiffxp
Copy link
Member

spiffxp commented Nov 23, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 11ebb63 into kubernetes:master Nov 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 23, 2020
@k8s-ci-robot
Copy link
Contributor

@ameukam: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key 1.17.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.17.yaml
  • key 1.18.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml
  • key 1.19.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.19.yaml
  • key bazel-build-test.yaml using file config/jobs/kubernetes/sig-testing/bazel-build-test.yaml

In response to this:

Part of #19073
Ref: #18550

Signed-off-by: Arnaud Meukam [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp mentioned this pull request Nov 23, 2020
Closed
@ameukam ameukam deleted the migrate-job-pull-k8s-bazel-build branch March 7, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
4 participants
@ameukam @justaugustus @k8s-ci-robot @spiffxp