Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a node e2e testjob with Podutils to validate migration #19942

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Create a node e2e testjob with Podutils to validate migration #19942

merged 1 commit into from
Nov 13, 2020

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Nov 13, 2020 •
edited
Loading

Signed-off-by: Ricardo Pchevuzinske Katz [email protected]

This will create a new Node e2e job, using podutil.

The Job is optional, and it was created to validate the migration of the critical job to podutils

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 13, 2020
@rikatz rikatz changed the title Update some jobs to podutils WIP: Update some jobs to podutils Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 13, 2020
@chaodaiG
Copy link
Contributor

/cc @BenTheElder @krzyzacy
For help on kubetest

@krzyzacy
Copy link
Member

/cc @amwat
/uncc

@k8s-ci-robot k8s-ci-robot requested review from amwat and removed request for krzyzacy November 13, 2020 17:43
alvaroaleman
alvaroaleman reviewed Nov 13, 2020
View reviewed changes
config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml Outdated
@@ -9,6 +9,10 @@ presubmits:
testgrid-create-test-group: "true"
testgrid-num-failures-to-alert: "10"
always_run: true
decorate: true
extra_refs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

presubmits don't need the extra_refs for the repo they run on and I think adding it will result in undefined behavior

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Removing!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@alvaroaleman if this is right, I can migrate all the jobs from sig-node here to podsubmits (it seems pretty 'trivial', as they use node configs).

Just don't know if there's a way to test like it is in production without actually merging it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to my knowledge its not possible to test job changes on prow.k8s.io without actually merging them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(You could copy the job, set optional: true on the copy, create a PR on k/k and check, then remove the copy and update the original here)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, seems that's the only way: #18338 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, right then :)

So I can just migrated the required pull-kubernetes-node-e2e to not have a big change.

I've followed your idea and created a similar job, with other name to test if it works :)

If this is ok we can follow this way and then I can start migrating some other jobs to podutils

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2020
@rikatz rikatz changed the title WIP: Update some jobs to podutils Create a node e2e testjob with Podutils to validate migration Nov 13, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2020
@chaodaiG
Copy link
Contributor

/lgtm
/approve
Looks good to me generally, since it's not blocking other PRs, let's try it out

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7886a00 into kubernetes:master Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 13, 2020
@k8s-ci-robot
Copy link
Contributor

@rikatz: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Signed-off-by: Ricardo Pchevuzinske Katz [email protected]

This will create a new Node e2e job, using podutil.

The Job is optional, and it was created to validate the migration of the critical job to podutils

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rikatz rikatz mentioned this pull request Nov 13, 2020
Merged
@spiffxp spiffxp mentioned this pull request Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman left review comments

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@vpickard vpickard Awaiting requested review from vpickard

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@amwat amwat Awaiting requested review from amwat

Assignees

@chaodaiG chaodaiG

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
5 participants
@rikatz @chaodaiG @krzyzacy @k8s-ci-robot @alvaroaleman