-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to log jobs using deprecated bootstrap, scenarios #20825
Conversation
FWIW, here's what I found running tests locally
|
/test pull-test-infra-bazel |
ref: #20760 for bootstrap migration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
If I can find time I would love to build a struct for each job that can hold a little more metadata and help determine owners to see that Sigs have the most depreciated jobs.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MushuEE, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I was sortof headed in that direction in experiment/prowjob-report. There are a number of policy changes we want rolled out across all jobs, but we'd rather delegate that work out to the appropriate job owners. e.g.
We have a bunch of distinct things that could imply ownership, I'm not sure how consistent they are:
ATM I wonder if it'd be best to try making path source of truth, and automatically added some labels at push-to-prow-time that could then end up in finished.json's metadata |
Same pattern as CI policy changes... start with "should" tests that log jobs using deprecated things.
This can be used to build a help-wanted list, or shard out issues to specific job owners, etc.
/cc @amwat @MushuEE