Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to log jobs using deprecated bootstrap, scenarios #20825

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Feb 10, 2021

Same pattern as CI policy changes... start with "should" tests that log jobs using deprecated things.

This can be used to build a help-wanted list, or shard out issues to specific job owners, etc.

/cc @amwat @MushuEE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 10, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Feb 10, 2021

FWIW, here's what I found running tests locally

jobs_test.go:1150: 403/2136 jobs do not use pod-utils
jobs_test.go:1192: 835/2136 jobs using deprecated scenarios

@spiffxp
Copy link
Member Author

spiffxp commented Feb 10, 2021

/test pull-test-infra-bazel
flake read tcp 10.60.209.54:51456->74.125.70.128:443: read: connection reset by peer

@spiffxp
Copy link
Member Author

spiffxp commented Feb 10, 2021

ref: #20760 for bootstrap migration

Copy link
Contributor

@MushuEE MushuEE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

If I can find time I would love to build a struct for each job that can hold a little more metadata and help determine owners to see that Sigs have the most depreciated jobs.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MushuEE, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cde78dc into kubernetes:master Feb 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 11, 2021
@spiffxp spiffxp deleted the survey-bootstrap-jobs branch February 11, 2021 16:34
@spiffxp
Copy link
Member Author

spiffxp commented Feb 11, 2021

If I can find time I would love to build a struct for each job that can hold a little more metadata and help determine owners to see that Sigs have the most depreciated jobs.

I was sortof headed in that direction in experiment/prowjob-report. There are a number of policy changes we want rolled out across all jobs, but we'd rather delegate that work out to the appropriate job owners. e.g.

  • setting alert e-mails for all jobs
  • setting pod resource limits for all jobs that run in k8s-infra
  • jobs shouldn't use bootstrap
  • jobs shouldn't use scenarios
  • jobs shouldn't use kubetest

We have a bunch of distinct things that could imply ownership, I'm not sure how consistent they are:

  • testgrid dashboard (but there can be many, I was guessing first sig- dashboard that wasn't sig-release)
  • testgrid alert e-mail (but there are many non-sig e-mails)
  • path for job / OWNER label for job (but this misses ownership of job results not produced by prow.kl8s.io that we ingest with kettle and testgrid)

ATM I wonder if it'd be best to try making path source of truth, and automatically added some labels at push-to-prow-time that could then end up in finished.json's metadata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants