Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cluster-api jobs for v1.25/v1.26 #27421

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Bump cluster-api jobs for v1.25/v1.26 #27421

merged 1 commit into from
Sep 8, 2022

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Sep 8, 2022 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 8, 2022
@sbueringer
Copy link
Member Author

sbueringer commented Sep 8, 2022 •
edited
Loading

cc @oscr @fabriziopandini

Would be great if we can maybe merge today so we have enough time until the v1.2.x release next week.

P.S. I have some ideas about how to automate all this, will follow-up as part of the release-team effort.
P.S. 2 The pull-test-infra-prow-checkconfig-beta is optional and is failing everywhere right so. So I thnk this shouldn't block this PR.

@sbueringer sbueringer mentioned this pull request Sep 8, 2022
Closed
29 tasks
@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-prow-checkconfig-beta f4256b9 link false /test pull-test-infra-prow-checkconfig-beta

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sbueringer
sbueringer commented Sep 8, 2022
View reviewed changes
config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml
@@ -130,11 +130,11 @@ periodics:
- name: GINKGO_FOCUS
value: "\\[clusterctl-Upgrade\\]"
- name: INIT_WITH_BINARY
value: https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.2.0/clusterctl-{OS}-{ARCH}
value: https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.2.1/clusterctl-{OS}-{ARCH}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this up-to-date on a best effort basis. So I just bumped it because I saw it. Similar in the 1-2 job yaml

sbueringer
sbueringer commented Sep 8, 2022
View reviewed changes
config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml
@@ -298,49 +298,4 @@ presubmits:
cpu: 7300m
annotations:
testgrid-dashboards: sig-cluster-lifecycle-cluster-api
testgrid-tab-name: capi-pr-e2e-main-1-24-latest
- name: pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We introduced this a while back to specifically test the CoreDNS/ RBAC thing on PRs. We don't need that anymore so I cleaned it up

fabriziopandini
fabriziopandini reviewed Sep 8, 2022
View reviewed changes
config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-2-upgrades.yaml
spec:
serviceAccountName: prowjob-default-sa
containers:
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20220903-da891f21aa-1.24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: should this be

Suggested change
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20220903-da891f21aa-1.24
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20220903-da891f21aa-1.25

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should stay on 1.24 as release-1.2 is using 1.24 dependencies + the go version used in v1.24 (1.18)

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b139e8d into kubernetes:master Sep 8, 2022
@k8s-ci-robot
Copy link
Contributor

@sbueringer: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-main-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml
  • key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml
  • key cluster-api-periodics-release-1-2-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-2-upgrades.yaml
  • key cluster-api-periodics-release-1-2.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-2.yaml
  • key cluster-api-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml
  • key cluster-api-presubmits-release-1-2.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-2.yaml

In response to this:

Part of kubernetes-sigs/cluster-api#6661

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-bump-capi-jobs-to-v1.25 branch September 8, 2022 12:59
This was referenced Nov 18, 2022
Closed
Closed
@ykakarap ykakarap mentioned this pull request Nov 30, 2022
Closed
13 tasks
@joekr joekr mentioned this pull request Apr 3, 2023
Closed
12 tasks
@ykakarap ykakarap mentioned this pull request May 20, 2023
Closed
13 tasks
@chrischdi chrischdi mentioned this pull request Aug 10, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbueringer @k8s-ci-robot @fabriziopandini