Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable stalebot in ingress-nginx #27512

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Sep 15, 2022

We are under a lot of heavy work. This doesn't mean we don't care for issues and PRs, but more that we couldn't check all the reports yet.

We need to do a better job, I know :) we all are contributors and do this for free. This doesn't mean we need to close issues and PRs because we couldn't even triage those.

So based on my experience as a contributor and how upset I get when I have to keep doing lifecycle active commands, I'm proposing that we remove the stale bot (as KinD and @BenTheElder did) so we don't simply close issues and PRs.

Based on this, and if accepted by other contributors, we have an agreement we need to start taking better care on PRs and issues, even at least saying to the user "ack, we are under heavy work but we understand that this is important to you and wont be automatically closed".

/cc @strongjz @tao12345666333 @ElvinEfendi

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2022
@k8s-ci-robot
Copy link
Contributor

@rikatz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-prow-checkconfig-beta 3b5e860 link false /test pull-test-infra-prow-checkconfig-beta

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rikatz
Copy link
Contributor Author

rikatz commented Sep 15, 2022

/hold
For discussion in our weekly community meeting

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2022
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

FWIW I've found this leads to less duplicate issues and more realistic issue counts, but it does mean manually opting to close out inactive support tickets.

I personally find that trade-off acceptable.

There's no particular rush to close issues that aren't labeled urgent and aren't receiving activity, but it is something you get a poor approximation of with no human effort from the bot. Notably on the other hand the bot cannot distinguish this from issues that simply aren't being worked on yet and therefore have nothing to add besides users politely adding +1 reactions that do not alter the timestamp and will not prevent closure.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@tao12345666333
Copy link
Member

One of my previous ideas was to have the bot filter by adding a specific label . But considering our actual situation, this may not be appropriate

@strongjz
Copy link
Member

In our community meeting today, we discussed having @cpanato update the bot so we can only label issues as stale and not close them.

This will help us track them but not close them.

@BenTheElder
Copy link
Member

To label without closing you only need to opt out of the close query, except then it will post a misleading comment when labeling them.

So instead all the jobs except the close job will need to be duplicated with new comments written 😅

Should not require code changes.

@cpanato
Copy link
Member

cpanato commented Sep 16, 2022

so we just need to opt-out from the ci-k8s-triage-robot-close job if i get that right

@BenTheElder @rikatz @strongjz

@BenTheElder
Copy link
Member

Yeah though if you do that when it labels the issues it will post the same comment it uses everywhere else which tells people that it will be auto closing it

@cpanato
Copy link
Member

cpanato commented Sep 16, 2022

@rikatz @strongjz if you dont want that we can drop everything and then have a gtihub action to label things for us with custom text and not close it

@BenTheElder
Copy link
Member

The robot commenter is general. The text is configured in the jobs (expand the diff).
It's just not configured on a per repo basis.

So instead all the jobs except the close job will need to be duplicated with new comments written 😅

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2022
@cpanato
Copy link
Member

cpanato commented Dec 22, 2022

ok, as we discussed we will disable the stale bot for now.

/lgtm
/unhold to continue the work

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2022
@cpanato
Copy link
Member

cpanato commented Dec 22, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2f5ed77 into kubernetes:master Dec 22, 2022
@k8s-ci-robot
Copy link
Contributor

@rikatz: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-contribex-k8s-triage-robot.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-contribex-k8s-triage-robot.yaml

In response to this:

We are under a lot of heavy work. This doesn't mean we don't care for issues and PRs, but more that we couldn't check all the reports yet.

We need to do a better job, I know :) we all are contributors and do this for free. This doesn't mean we need to close issues and PRs because we couldn't even triage those.

So based on my experience as a contributor and how upset I get when I have to keep doing lifecycle active commands, I'm proposing that we remove the stale bot (as KinD and @BenTheElder did) so we don't simply close issues and PRs.

Based on this, and if accepted by other contributors, we have an agreement we need to start taking better care on PRs and issues, even at least saying to the user "ack, we are under heavy work but we understand that this is important to you and wont be automatically closed".

/cc @strongjz @tao12345666333 @ElvinEfendi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants