-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable stalebot in ingress-nginx #27512
Conversation
@rikatz: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
FWIW I've found this leads to less duplicate issues and more realistic issue counts, but it does mean manually opting to close out inactive support tickets.
I personally find that trade-off acceptable.
There's no particular rush to close issues that aren't labeled urgent and aren't receiving activity, but it is something you get a poor approximation of with no human effort from the bot. Notably on the other hand the bot cannot distinguish this from issues that simply aren't being worked on yet and therefore have nothing to add besides users politely adding +1 reactions that do not alter the timestamp and will not prevent closure.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
One of my previous ideas was to have the bot filter by adding a specific label . But considering our actual situation, this may not be appropriate |
In our community meeting today, we discussed having @cpanato update the bot so we can only label issues as stale and not close them. This will help us track them but not close them. |
To label without closing you only need to opt out of the close query, except then it will post a misleading comment when labeling them. So instead all the jobs except the close job will need to be duplicated with new comments written 😅 Should not require code changes. |
so we just need to opt-out from the |
Yeah though if you do that when it labels the issues it will post the same comment it uses everywhere else which tells people that it will be auto closing it |
The robot commenter is general. The text is configured in the jobs (expand the diff).
|
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
ok, as we discussed we will disable the stale bot for now. /lgtm |
/hold cancel |
@rikatz: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We are under a lot of heavy work. This doesn't mean we don't care for issues and PRs, but more that we couldn't check all the reports yet.
We need to do a better job, I know :) we all are contributors and do this for free. This doesn't mean we need to close issues and PRs because we couldn't even triage those.
So based on my experience as a contributor and how upset I get when I have to keep doing
lifecycle active
commands, I'm proposing that we remove the stale bot (as KinD and @BenTheElder did) so we don't simply close issues and PRs.Based on this, and if accepted by other contributors, we have an agreement we need to start taking better care on PRs and issues, even at least saying to the user "ack, we are under heavy work but we understand that this is important to you and wont be automatically closed".
/cc @strongjz @tao12345666333 @ElvinEfendi