bootstrap.py: perform "blobless" clones #28954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
significantly reduce time and bandwidth cloning kubernetes in particular https://github.blog/2020-12-21-get-up-to-speed-with-partial-clone-and-shallow-clone/
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/testing
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
will wait to merge this until on hand to revert, just in case. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
this doesn't appear to be causing any issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should significantly reduce time and bandwidth cloning github.com/kubernetes/kubernetes in particular.
https://github.blog/2020-12-21-get-up-to-speed-with-partial-clone-and-shallow-clone/
pod-utils hopefully next ref #26590 #18226 (comment)
bootstrap.py is simpler to tweak and AFAIK nobody else is using it besides kubernetes CI (and if they are, it's officially unsupported for years now anyhow) but affects a ton of Kubernetes CI jobs still, this is a single flag that is similar to a shallow clone without the broken
git describeissue.The only downside here is commands like
git blameandgit checkoutcan take longer as they have to fetch the missing blobs for the refs. We still fetch the history tree, tags, and the current blobs for the refs we fetch.It seems very unlikely that we have any regression from this change ™️ but it should speed things up, and help inform changing pod-utils defaults.
/hold
cc @listx