Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pull-hydrophone-namespaced-run job #32397

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Apr 7, 2024

This is the follow-up to kubernetes-sigs/hydrophone#171, creating a new job to test the namespaced execution of hydrophone.

This PR also removes the hardcoded Kube/kind versions, allowing the in-repo script to default the values. This should make it much easier to bump dependencies in hydrophone without having to make dedicated PRs here everytime.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 7, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @xrstf. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 7, 2024
@rjsadow
Copy link
Contributor

rjsadow commented Apr 7, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2024
@dims
Copy link
Member

dims commented Apr 8, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 560cd7d into kubernetes:master Apr 8, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@xrstf: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key hydrophone-periodic.yaml using file config/jobs/kubernetes-sigs/hydrophone/hydrophone-periodic.yaml
  • key hydrophone-presubmit.yaml using file config/jobs/kubernetes-sigs/hydrophone/hydrophone-presubmit.yaml

In response to this:

This is the follow-up to kubernetes-sigs/hydrophone#171, creating a new job to test the namespaced execution of hydrophone.

This PR also removes the hardcoded Kube/kind versions, allowing the in-repo script to default the values. This should make it much easier to bump dependencies in hydrophone without having to make dedicated PRs here everytime.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf xrstf deleted the namespaced-hydrophone-job branch April 8, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants