-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiarch build support for etcd #32672
Add multiarch build support for etcd #32672
Conversation
4411f63
to
4a24102
Compare
4a24102
to
7d3c7f6
Compare
3840504
to
118322d
Compare
118322d
to
27dc392
Compare
This approach slightly differs from what I used to migrate the integration tests. In that case, I took an approach of one matrix target per one prow job, as suggested by @jmhbnz. James, do you have any thoughts on this? It'd be good to align on this to ensure consistency with other jobs. /cc @jmhbnz |
Hey - I'm happy either way for this one. If we go with a single job the build doesn't take super long even if doing a |
27dc392
to
4d59962
Compare
This commit will add support for building multiarch etcd as a part of `pull-etcd-build` using `make build-all`. Signed-off-by: ArkaSaha30 <[email protected]>
4d59962
to
1097594
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Thanks @ArkaSaha30
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArkaSaha30, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ArkaSaha30: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This job was migrated to the prow infrastructre in May (kubernetes/test-infra#32672). It should be fine to delete the GitHub workflow, to remove duplicated jobs. Signed-off-by: Ivan Valdes <[email protected]>
This job was migrated to the prow infrastructure in May (kubernetes/test-infra#32672). Deleting the GitHub workflow to remove duplicate jobs should be fine. Signed-off-by: Ivan Valdes <[email protected]>
This job was migrated to the prow infrastructure in May (kubernetes/test-infra#32672). Deleting the GitHub workflow to remove duplicate jobs should be fine. Signed-off-by: Ivan Valdes <[email protected]>
This job was migrated to the prow infrastructure in May (kubernetes/test-infra#32672). Deleting the GitHub workflow to remove duplicate jobs should be fine. Signed-off-by: Ivan Valdes <[email protected]>
This PR will add support for building multiarch etcd as a part of
pull-etcd-build
presubmit job.Fixes: etcd-io/etcd#18064