Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiarch build support for etcd #32672

Merged
merged 1 commit into from
May 30, 2024

Conversation

ArkaSaha30
Copy link
Member

This PR will add support for building multiarch etcd as a part of pull-etcd-build presubmit job.

Fixes: etcd-io/etcd#18064

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2024
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label May 28, 2024
@k8s-ci-robot k8s-ci-robot added area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 28, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2024
@ArkaSaha30 ArkaSaha30 force-pushed the etcd-multiarch-build branch 2 times, most recently from 3840504 to 118322d Compare May 28, 2024 08:33
@ivanvc
Copy link
Member

ivanvc commented May 28, 2024

This approach slightly differs from what I used to migrate the integration tests. In that case, I took an approach of one matrix target per one prow job, as suggested by @jmhbnz. James, do you have any thoughts on this?

It'd be good to align on this to ensure consistency with other jobs.

/cc @jmhbnz

@k8s-ci-robot k8s-ci-robot requested a review from jmhbnz May 28, 2024 18:08
@jmhbnz
Copy link
Member

jmhbnz commented May 29, 2024

This approach slightly differs from what I used to migrate the integration tests. In that case, I took an approach of one matrix target per one prow job, as suggested by @jmhbnz. James, do you have any thoughts on this?

It'd be good to align on this to ensure consistency with other jobs.

Hey - I'm happy either way for this one. If we go with a single job the build doesn't take super long even if doing a build-all. If we want to have separate jobs to be consistent with the matrix approach from the github action that is also ok with me. This is something we can easily iterate on if needed.

This commit will add support for building
multiarch etcd as a part of `pull-etcd-build`
using `make build-all`.

Signed-off-by: ArkaSaha30 <[email protected]>
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thanks @ArkaSaha30

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArkaSaha30, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5d881d3 into kubernetes:master May 30, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ArkaSaha30: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-presubmits.yaml using file config/jobs/etcd/etcd-presubmits.yaml

In response to this:

This PR will add support for building multiarch etcd as a part of pull-etcd-build presubmit job.

Fixes: etcd-io/etcd#18064

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ivanvc added a commit to ivanvc/etcd that referenced this pull request Sep 23, 2024
This job was migrated to the prow infrastructre in May
(kubernetes/test-infra#32672). It should be fine
to delete the GitHub workflow, to remove duplicated jobs.

Signed-off-by: Ivan Valdes <[email protected]>
ivanvc added a commit to ivanvc/etcd that referenced this pull request Sep 23, 2024
This job was migrated to the prow infrastructure in May
(kubernetes/test-infra#32672). Deleting the
GitHub workflow to remove duplicate jobs should be fine.

Signed-off-by: Ivan Valdes <[email protected]>
a-nych pushed a commit to a-nych/etcd that referenced this pull request Oct 16, 2024
This job was migrated to the prow infrastructure in May
(kubernetes/test-infra#32672). Deleting the
GitHub workflow to remove duplicate jobs should be fine.

Signed-off-by: Ivan Valdes <[email protected]>
a-nych pushed a commit to a-nych/etcd that referenced this pull request Oct 16, 2024
This job was migrated to the prow infrastructure in May
(kubernetes/test-infra#32672). Deleting the
GitHub workflow to remove duplicate jobs should be fine.

Signed-off-by: Ivan Valdes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multiarch builds to prow build presubmit
6 participants