Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split AC and CAS metrics #6932

Merged
merged 1 commit into from
Feb 22, 2018
Merged

split AC and CAS metrics #6932

merged 1 commit into from
Feb 22, 2018

Conversation

BenTheElder
Copy link
Member

also drops the maps for struct fields per @cjwagner's previous suggestion

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 22, 2018
@BenTheElder
Copy link
Member Author

/assign @ixdy
/area bazel

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 22, 2018
@BenTheElder
Copy link
Member Author

/assign @krzyzacy
updated the graph to use this here: http://velodrome.k8s.io/dashboard/db/cache-monitoring

@BenTheElder BenTheElder mentioned this pull request Feb 22, 2018
Closed
12 tasks
cjwagner
cjwagner approved these changes Feb 22, 2018
View reviewed changes
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2018
@krzyzacy
Copy link
Member

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cjwagner, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,cjwagner,krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

/hold cancel
Will probably look into per-repo metrics as well, so far we basically just see that test-infra builds lots of things and caches exceptionally well (glares at hack/verify-pylint)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 08d56e6 into kubernetes:master Feb 22, 2018
@BenTheElder BenTheElder deleted the ACvsCAS branch February 22, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner cjwagner approved these changes

Assignees

@krzyzacy krzyzacy

@cjwagner cjwagner

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bazel cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BenTheElder @krzyzacy @k8s-ci-robot @cjwagner @ixdy