Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start to seperate lint and unit test #7041

Merged
merged 2 commits into from
Feb 28, 2018

Conversation

BenTheElder
Copy link
Member

bazel test //... will still run all bazel tests, however now you can run bazel test //... --config=unit to ignore our not-quite-hermetic lint tests, and bazel test //... --config=lint to only do lint.

This will let us split these pull-test-infra-bazel job into one job with build+unit tests and another that only does lints. The former should be a 100% cacheable presubmit and I expect this job to take ~one minute after this change. We'll have another job to install python deps and perform linting in ~2 minutes.

xref: #6865 #6808

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 27, 2018
@BenTheElder
Copy link
Member Author

... which should drive down our overall presubmit time to ~2 minutes once we make the switch. I'm defering that until after we've validated these new job configs.

@BenTheElder
Copy link
Member Author

/assign @ixdy @krzyzacy

@BenTheElder
Copy link
Member Author

/area jobs
/area bazel

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2018
Copy link
Member

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit afe86b7 into kubernetes:master Feb 28, 2018
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the config configmap

In response to this:

bazel test //... will still run all bazel tests, however now you can run bazel test //... --config=unit to ignore our not-quite-hermetic lint tests, and bazel test //... --config=lint to only do lint.

This will let us split these pull-test-infra-bazel job into one job with build+unit tests and another that only does lints. The former should be a 100% cacheable presubmit and I expect this job to take ~one minute after this change. We'll have another job to install python deps and perform linting in ~2 minutes.

xref: #6865 #6808

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bazel area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants