-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start to seperate lint and unit test #7041
Conversation
... which should drive down our overall presubmit time to ~2 minutes once we make the switch. I'm defering that until after we've validated these new job configs. |
/area jobs |
51c56f9
to
5b8a24a
Compare
5b8a24a
to
3881ce7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, krzyzacy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@BenTheElder: Updated the config configmap In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bazel test //...
will still run all bazel tests, however now you can runbazel test //... --config=unit
to ignore our not-quite-hermetic lint tests, andbazel test //... --config=lint
to only do lint.This will let us split these
pull-test-infra-bazel
job into one job with build+unit tests and another that only does lints. The former should be a 100% cacheable presubmit and I expect this job to take ~one minute after this change. We'll have another job to install python deps and perform linting in ~2 minutes.xref: #6865 #6808