Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with k8s invalid link referred by "framework file" in docs k8s.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definition-versioning/ #13759

Closed
shubham-asati opened this issue Apr 11, 2019 · 1 comment
Closed

Issue with k8s invalid link referred by "framework file" in docs k8s.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definition-versioning/ #13759

shubham-asati opened this issue Apr 11, 2019 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@shubham-asati
Copy link
Contributor

shubham-asati commented Apr 11, 2019 •
edited
Loading

This is a Bug Report

Problem:
Invalid link referred by "framework file" in "Most of the common code are located in the framework file that leaves only one function to be implemented for different conversions."
It was supposed to redirect to github page but invalid link reference of "framework file" leads to error 404 page not found.

Proposed Solution:
Linking "framework file" in "Most of the common code are located in the framework file that leaves only one function to be implemented for different conversions." to a valid link that fulfill the context.

Page to Update:
k8s.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definition-versioning/

Kubernetes Version
v1.14
@shubham-asati shubham-asati added the kind/bug Categorizes issue or PR as related to a bug. label Apr 11, 2019
@shubham-asati shubham-asati changed the title Issue with k8s.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definition-versioning/ Issue with k8s invalid link referred by "framework file" in docs k8s.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definition-versioning/ Apr 12, 2019
@shubham-asati
Copy link
Contributor Author

i am working on this issue.

@shubham-asati shubham-asati mentioned this issue Apr 18, 2019
Merged
k8s-ci-robot pushed a commit that referenced this issue Apr 19, 2019
@shubham-asati @k8s-ci-robot
updated link for framework file (#13868)
358d136 
* updated link for framework file 

Fixed the invalid link referred by "framework file" in "Most of the common code are located in the framework file that leaves only one function to be implemented for different conversions.". 
This fix is for the issue #13759 .

* updated framework file link reference to v1.14

changed docs version from v1.13.0 to v1.14.0 in the link reference  
"framework file" -> https://github.com/kubernetes/kubernetes/tree/v1.14.0/test/images/crd-conversion-webhook/converter/framework.go
nowjean pushed a commit to nowjean/website that referenced this issue Jun 13, 2019
@shubham-asati @nowjean
updated link for framework file (kubernetes#13868)
9c1ddae 
* updated link for framework file 

Fixed the invalid link referred by "framework file" in "Most of the common code are located in the framework file that leaves only one function to be implemented for different conversions.". 
This fix is for the issue kubernetes#13759 .

* updated framework file link reference to v1.14

changed docs version from v1.13.0 to v1.14.0 in the link reference  
"framework file" -> https://github.com/kubernetes/kubernetes/tree/v1.14.0/test/images/crd-conversion-webhook/converter/framework.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shubham-asati