Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangling "pick-right-solution" references - Korean #14479

Closed
sethmccombs opened this issue May 22, 2019 · 8 comments
Closed

Dangling "pick-right-solution" references - Korean #14479

sethmccombs opened this issue May 22, 2019 · 8 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. language/ko Issues or PRs related to Korean language

Comments

@sethmccombs
Copy link
Contributor

This is a Bug Report
Problem:

The link from "Cluster Administration Overview" to " Picking the Right Solution" is a 404.
docs/setup/pick-right-solution/ does not exist, as it was removed as a redundant page.

Proposed Solution:
Update the stale links to point to Setup page not the "Picking the Right Solution" page
The references on this page point both too the root of the pick-right-solution page, but also to various IDs that no longer exist, there may be better pages to point those links to.

Page to Update:
https://kubernetes.io/ko/docs/setup/
https://kubernetes.io/ko/docs/tutorials/stateful-application/cassandra/

@sethmccombs
Copy link
Contributor Author

/good-first-issue
/language ko

@k8s-ci-robot
Copy link
Contributor

@sethmccombs:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/language ko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 22, 2019
@seokho-son
Copy link
Member

Hello, @sethmccombs !
I am one of the reviewers for Korean localization contents.
Thank you for issuing the problem.
In case of Korean localization team, we periodically (2 or 3 weeks) create a working branch and apply translated documents by merging the working branch.
So, in general, we don't immediately reflect changes in English contents in Master branch to Korean contents in Master branch.
I think Korean localization team can handle this issue by taking care of outdated files when we change our working branch from dev-1.14-ko.4 (current) to dev-1.14-ko.5 (next).

@gochist
A merged PR in the master (English) branch removed "Picking the Right Solution" page.
Do you think this issue can be handled by taking care of outdated files in dev-1.14-ko.5 ?

@sethmccombs
Copy link
Contributor Author

Hey @seokho-son, sounds like this one will get taken care of when you change working branches. The removed page impacted most translations, and I figured the editing the links was a good first issue, so I logged one for all languages, so feel free to take care of this one in any way you see fit!

@gochist
Copy link
Member

gochist commented May 23, 2019

@sethmccombs @seokho-son Thank you! I think this is a good first issue too. Korean l10n team do not use GitHub milestone, however the milestone of this issue will be dev-1.14-ko.5.

@gochist
Copy link
Member

gochist commented Jun 27, 2019

This issue is included in #15001 and #15029 .

k8s-ci-robot pushed a commit that referenced this issue Jul 9, 2019
* Updated Korean setup and cassandra pages to remove broken pick-right-solution page

* took out the errant Getting Started line with the pick-right-solution link.  It's not in the English version at all.
@gochist
Copy link
Member

gochist commented Jul 24, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@gochist: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. language/ko Issues or PRs related to Korean language
Projects
None yet
Development

No branches or pull requests

4 participants