Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureDisk storage class parameters are incomplete #15741

Closed
easimon opened this issue Aug 8, 2019 · 5 comments · Fixed by #16841
Closed

AzureDisk storage class parameters are incomplete #15741

easimon opened this issue Aug 8, 2019 · 5 comments · Fixed by #16841
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@easimon
Copy link

easimon commented Aug 8, 2019

This is a Feature Request

On https://kubernetes.io/docs/concepts/storage/storage-classes/#azure-disk, the list of configuration properties for Azure Disks is incomplete. I found https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/docs/driver-parameters.md for the new CSI driver and found the parameter resourceGroup documented there -- which was exactly what I was searching for.

It seems that the "old" built-in AzureDisk provider supports this as well. I added that parameter to my storage class, and it created disks connected to that storage class in the specified resource group automatically. So the parameter is working, just not documented.

What would you like to be added

Something like this, in the existing AzureDisk section.

  • resourceGroup: specify the resource group in which azure disk will be created.Must be an existing resource group name. If unspecified, disk will be placed in the the same resource group as current k8s cluster

Why is this needed

Completeness of documentation

@thecrudge
Copy link
Contributor

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@thecrudge:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 10, 2019
@mcurtiscmu
Copy link

I would like to work on this issue.

@sftim
Copy link
Contributor

sftim commented Oct 4, 2019

/priority backlog
@mcurtiscmu did you want to propose a fix for this?

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Oct 4, 2019
@vishakhanihore
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants