Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with docs/concepts/architecture/controller.md URL links are mixed in the document. #16877

Closed
ysyukr opened this issue Oct 14, 2019 · 4 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@ysyukr
Copy link
Member

ysyukr commented Oct 14, 2019

This is a Bug Report

Problem:
Unlike other documents, links in the document are listed as full URLs.
ex)
Cluster autoscaling - https://kubernetes.io/docs/tasks/administer-cluster/cluster-management/#cluster-autoscaling
Kubernetes control plane - https://kubernetes.io/docs/concepts/#kubernetes-control-plane
Kubernetes objects - https://kubernetes.io/docs/concepts/#kubernetes-objects

Proposed Solution:
Change the link above to the following:
Cluster autoscaling - /docs/tasks/administer-cluster/cluster-management/#cluster-autoscaling
Kubernetes control plane - /docs/concepts/#kubernetes-control-plane
Kubernetes objects - /docs/concepts/#kubernetes-objects

Page to Update:
https://kubernetes.io/docs/concepts/architecture/controller/

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 14, 2019
@ysyukr
Copy link
Member Author

ysyukr commented Oct 14, 2019

/assign

@sftim
Copy link
Contributor

sftim commented Oct 14, 2019

Good spot
/kind cleanup
/priority backlog

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Oct 14, 2019
@ysyukr
Copy link
Member Author

ysyukr commented Oct 14, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@ysyukr: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

3 participants