Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy list of generators for “kubectl create” #25501

Closed
sftim opened this issue Dec 8, 2020 · 8 comments
Closed

Tidy list of generators for “kubectl create” #25501

sftim opened this issue Dec 8, 2020 · 8 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Dec 8, 2020

This is a Feature Request

What would you like to be added
Convert the monospaced list of kubectl create generators into Markdown that renders as nice HTML.

Why is this needed
https://kubernetes.io/docs/reference/kubectl/conventions/#generators lists generators, as monospaced text.
This would render better as an unordered list.

Comments
/language en
/kind cleanup
/good-first-issue

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 8, 2020
@k8s-ci-robot
Copy link
Contributor

@sftim:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

This is a Feature Request

What would you like to be added
Convert the monospaced list of kubectl create generators into Markdown that renders as nice HTML.

Why is this needed
https://kubernetes.io/docs/reference/kubectl/conventions/#generators lists generators, as monospaced text.
This would render better as an unordered list.

Comments
/language en
/kind cleanup
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 8, 2020
@sftim
Copy link
Contributor Author

sftim commented Dec 8, 2020

/triage accepted
/sig docs

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/docs Categorizes an issue or PR as relevant to SIG Docs. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 8, 2020
@tomkivlin
Copy link
Contributor

/assign

@tomkivlin
Copy link
Contributor

@sftim is there some automation to close an issue that has been resolved by PR, or do I just ask here? :)

@irvifa
Copy link
Member

irvifa commented Jan 12, 2021

@tomkivlin you can use this https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue when creating a PR. You can do this on commit description or on your commit message.

@tomkivlin
Copy link
Contributor

@irvifa sure, thanks. I wasn't sure if this was discouraged in the PR guidelines but will add to the PR level next time.

@tengqm
Copy link
Contributor

tengqm commented Jan 13, 2021

Resolved.
/close

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closing this issue.

In response to this:

Resolved.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants