Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between API resources vs. field definitions (subresources) #26415

Closed
sftim opened this issue Feb 7, 2021 · 9 comments
Closed

Distinguish between API resources vs. field definitions (subresources) #26415

sftim opened this issue Feb 7, 2021 · 9 comments
Labels
language/en Issues or PRs related to English language lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Feb 7, 2021

This is a Feature Request

What would you like to be added
Distinguish between API resources vs. field definitions in the API reference. This distinction should appear in both listings and in detailed pages such as https://k8s.io/docs/reference/kubernetes-api/workloads-resources/ephemeral-containers-v1/

Ideally the reader also understands whether and why the field definition / subresource is or isn't versioned (compare /docs/reference/kubernetes-api/workloads-resources/ephemeral-containers-v1/ to /docs/reference/kubernetes-api/workloads-resources/container/)

Why is this needed
On a page such as https://kubernetes.io/docs/reference/kubernetes-api/workloads-resources/ I can (currently) see
the first 5 items:

  1. Pod Pod is a collection of containers that can run on a host.
  2. Container A single application container that you want to run within a pod.
  3. EphemeralContainer An EphemeralContainer is a container that may be added temporarily to an existing pod for user-initiated activities such as debugging.
  4. PodTemplate PodTemplate describes a template for creating copies of a predefined pod.
  5. ReplicationController ReplicationController represents the configuration of a replication controller.

I know that I can send a HTTP request to query Pod and ReplicationController resources from the API. These are indeed resources in the HTTP sense of the term. However, for others such as PodTemplateContainer, those (as I see it) define the structure of fields within other resources. It's important to document those fields and their definitions, but it's also helpful for the reader to understand which items are actually resources that they can interact with directly via the API.

Comments

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 7, 2021
@sftim
Copy link
Contributor Author

sftim commented Feb 7, 2021

/sig architecture
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Feb 7, 2021
@sftim
Copy link
Contributor Author

sftim commented Feb 7, 2021

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 7, 2021
@sftim
Copy link
Contributor Author

sftim commented Feb 7, 2021

@feloy I'd be interested to learn your thoughts on this. I think it's a matter not just for the specific API generator that you led the work on - there are also open questions about how we explain these differences more generally.

@kbhawkey
Copy link
Contributor

kbhawkey commented Feb 8, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 8, 2021
@sftim
Copy link
Contributor Author

sftim commented Feb 15, 2021

Relevant to #25505

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 16, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 15, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants