Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with /docs/concepts/services-networking/service/ #3735

Closed
1 of 3 tasks
erikbgithub opened this issue May 13, 2017 · 10 comments
Closed
1 of 3 tasks

Issue with /docs/concepts/services-networking/service/ #3735

erikbgithub opened this issue May 13, 2017 · 10 comments
Assignees
Labels
language/en Issues or PRs related to English language lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@erikbgithub
Copy link

This is a...

  • Feature Request
  • Bug Report
  • Documentation Changerequest

Problem:
The linked page (also here) describes external access to internal services via NodePort. But when I talk to people who really know Kubernetes well they always suggest to externalize services via Ingress. Without this info at the NodePort spot newcomers stop after reading about NodePorts and don't even get to the Ingress page. I mean, who reads the whole manual when one's questions are already (seemingly) answered, right?

Proposed Solution:
The page should mention Ingress, and probably how the Kubernetes stands to the NodePort vs Ingress question. My guess would be that more and more people want Ingresses instead of NodePorts, because they seem to also support other features that is required with externalization like Loadbalancing (which you don't have automatically in bare metal installations).

Page to Update:
https://kubernetes.io/docs/concepts/services-networking/service/

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2017
@tengqm
Copy link
Contributor

tengqm commented Dec 24, 2017

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 24, 2017
@palnabarun
Copy link
Member

@sftim Will #14526 address this? If not, can I work on this?

@sftim
Copy link
Contributor

sftim commented Jun 3, 2019

PR #14526 will help, I hope. There's yet more to do afterwards. I think the main page about the Service concept should talk less about implementation details like AWS load balancers, and more about different ways of handling ingress (eg Ingress, Istio, Gloo).

Because #14526 is a big set of changes, I think it makes sense to build on it once merged.

@palnabarun you could sketch out (in your mind, on paper, using Git, whatever) what that documentation might look like in the future, even before #14526 is ready to merge. Does that sound alright?

@sftim
Copy link
Contributor

sftim commented Jun 3, 2019

/language en

@palnabarun
Copy link
Member

@sftim Sure. I would make a note of it.

What I felt is, right now as a temporary measure we can add the reference to Ingress and Ingress Controller in the Service documentation so that readers get pointed to the right direction and learn more about it.

@sftim
Copy link
Contributor

sftim commented Jun 7, 2019

How about closing this in favor of #14770?

@palnabarun
Copy link
Member

Sure. We can track about refactoring the Service documentation on #14770

@sethmccombs
Copy link
Contributor

/assign
/close

@k8s-ci-robot
Copy link
Contributor

@sethmccombs: Closing this issue.

In response to this:

/assign
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

8 participants