Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate BlockVolume feature to beta #10100

Merged
merged 2 commits into from
Dec 1, 2018
Merged

Graduate BlockVolume feature to beta #10100

merged 2 commits into from
Dec 1, 2018

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Aug 27, 2018

docs for feature kubernetes/enhancements#351

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 27, 2018 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit 84d1e0a

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5c0302c20097d4092d750233

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 27, 2018
@wongma7 wongma7 mentioned this pull request Aug 27, 2018
Closed
@Bradamant3 Bradamant3 added this to the 1.12 milestone Aug 27, 2018
@zparnold
Copy link
Member

@wongma7 Now that this is in beta, does it need more documentation surrounding it?

@justaugustus
Copy link
Member

@xiangpengzhao @zhangxiaoyu-zidif -- what's the status of this? These docs are overdue and we haven't heard any status updates on the associated feature issue.

I'm removing this from the milestone per this comment.

If you feel this is incorrect, please respond ASAP.

/milestone clear

@xiangpengzhao
Copy link
Contributor

@wongma7 please confirm @justaugustus concern :)

@zparnold zparnold removed this from the 1.12 milestone Sep 12, 2018
@zparnold
Copy link
Member

/close

Feel free to reopen if you want to start this again. 😄

@k8s-ci-robot
Copy link
Contributor

@zparnold: Closing this PR.

In response to this:

/close

Feel free to reopen if you want to start this again. 😄

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tfogo tfogo changed the base branch from release-1.12 to dev-1.13 November 1, 2018 23:32
@tfogo
Copy link
Contributor

tfogo commented Nov 2, 2018

/open

@tfogo
Copy link
Contributor

tfogo commented Nov 2, 2018

/reopen

@k8s-ci-robot
Copy link
Contributor

@tfogo: Reopening this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Nov 2, 2018
@tfogo tfogo added this to the 1.13 milestone Nov 3, 2018
@tfogo
Copy link
Contributor

tfogo commented Nov 19, 2018

Hi @wongma7, can you please complete this PR and let us know when it's ready for review? The docs deadline is approaching fast so we want to start reviewing PRs ASAP.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 20, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2018
@wongma7
Copy link
Contributor Author

wongma7 commented Nov 20, 2018

oops i rebased on master instead of dev zzzz

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 20, 2018
@wongma7 wongma7 changed the title [WIP] Graduate BlockVolume feature to beta Graduate BlockVolume feature to beta Nov 20, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2018
@idealhack idealhack removed language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language labels Nov 20, 2018
msau42
msau42 reviewed Nov 20, 2018
View reviewed changes
content/en/docs/concepts/storage/persistent-volumes.md
@@ -300,11 +300,12 @@ Currently, storage size is the only resource that can be set or requested. Futu
### Volume Mode

{{< feature-state for_k8s_version="v1.9" state="alpha" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question for docs: do we still need the alpha info?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated because the pr is targeting dev-1.13 branch.

content/en/docs/concepts/storage/persistent-volumes.md Outdated
@@ -616,19 +617,10 @@ Volume binding matrix for statically provisioned volumes:

| PV volumeMode | PVC volumeMode | Result |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify this table to just say volumeMode on PVC and PV must match?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduced to "PersistentVolumeClaims will only be bound to PersistentVolumes with the same volumeMode." c90a2a8#diff-bd23e5d028a7006d4c9e9cd8db0d5eabR614

@msau42 msau42 mentioned this pull request Nov 20, 2018
Merged
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2018
msau42
msau42 reviewed Nov 20, 2018
View reviewed changes
content/en/docs/concepts/storage/persistent-volumes.md Outdated
{{< note >}}
**Note:** Only statically provisioned volumes are supported for alpha release. Administrators should take care to consider these values when working with raw block devices.
{{< /note >}}
`PersistentVolumeClaims` will only be bound to `PersistentVolumes` with the same `volumeMode.`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe one sentence is too small for an entire section. Would it make sense to merge it with the above section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, moved to some place above

@msau42
Copy link
Member

msau42 commented Nov 21, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2018
@tengqm
Copy link
Contributor

tengqm commented Nov 25, 2018

/lgtm

@tfogo
Copy link
Contributor

tfogo commented Nov 27, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tfogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2018
@tfogo
Copy link
Contributor

tfogo commented Dec 1, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit 055a566 into kubernetes:dev-1.13 Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@xiangpengzhao xiangpengzhao xiangpengzhao left review comments

@tengqm tengqm tengqm left review comments

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@tfogo tfogo

@tengqm tengqm

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.13
Development

Successfully merging this pull request may close these issues.