Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix key name in pod-configmap-volume-specific-key.yaml example #13599

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Fix key name in pod-configmap-volume-specific-key.yaml example #13599

merged 1 commit into from
Apr 19, 2019

Conversation

julio-lopez
Copy link
Contributor

Changes the key name to SPECIAL_LEVEL in the config map volume definition.
This is consistent with the rest of the example. Otherwise, this pod does not
start because there is no key with that name in the special-config config map.

@julio-lopez
Fix key name in pod-configmap-volume-specific-key.yaml example
cf3aeb7 
Changes the key name to `SPECIAL_LEVEL` in the config map volume definition.
This is consistent with the rest of the example. Otherwise, this pod does not
start because there is no key with that name in the `special-config` config map.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2019
@netlify
Copy link

netlify bot commented Apr 3, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit cf3aeb7

https://deploy-preview-13599--kubernetes-io-master-staging.netlify.com

@DanyC97 DanyC97 mentioned this pull request Apr 4, 2019
Closed
@DanyC97
Copy link
Contributor

DanyC97 commented Apr 4, 2019

@julio-lopez thank you for the fix.

first can you please sign the CLA?

@tengqm
Copy link
Contributor

tengqm commented Apr 15, 2019

@julio-lopez ping for CLA status

@julio-lopez
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 17, 2019
@DanyC97
Copy link
Contributor

DanyC97 commented Apr 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2019
@Bradamant3
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5621bc1 into kubernetes:master Apr 19, 2019
nowjean pushed a commit to nowjean/website that referenced this pull request Jun 13, 2019
@julio-lopez @nowjean
Fix key name in pod-configmap-volume-specific-key.yaml example (kuber…
3f84848 
…netes#13599)

Changes the key name to `SPECIAL_LEVEL` in the config map volume definition.
This is consistent with the rest of the example. Otherwise, this pod does not
start because there is no key with that name in the `special-config` config map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@DanyC97 DanyC97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@julio-lopez @k8s-ci-robot @DanyC97 @tengqm @Bradamant3