-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a word order issue #13811
fix a word order issue #13811
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 5869718 https://deploy-preview-13811--kubernetes-io-master-staging.netlify.com |
/assign @zparnold |
/assign @rlenferink |
imo both are valid and so i don't think worth the change. Saying that will let the other sig-docs members to weigh in |
It confuses me who is a non English native user. |
(non-native English speaker over as well). Imo both are valid, but for me the old sentence is the easiest to read. Lets ask @Bradamant3 for input ;) /assign @Bradamant3 |
Strictly speaking the original is preferable; the change is more formal and less common in American English at least (which has for better or worse become a standard reference point). That said, comments from non-native speakers are our best data and feedback. Adding one more fix to clear up for I hope everybody (native and non-native speakers), and changing a couple of other headings so that we maintain parallelism. |
@ptux thanks for noticing -- the eventual fix is a bit different from what you proposed, but it's an excellent catch overall. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bradamant3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for your consideration to non-native speakers. |
* fix a word order issue * Normalize heading language
No description provided.