Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a word order issue #13811

Merged
merged 2 commits into from
Apr 19, 2019
Merged

fix a word order issue #13811

merged 2 commits into from
Apr 19, 2019

Conversation

ptux
Copy link
Contributor

@ptux ptux commented Apr 14, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 14, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 14, 2019
@netlify
Copy link

netlify bot commented Apr 14, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5869718

https://deploy-preview-13811--kubernetes-io-master-staging.netlify.com

@ptux
Copy link
Contributor Author

ptux commented Apr 15, 2019

/assign @zparnold

@ptux
Copy link
Contributor Author

ptux commented Apr 16, 2019

/assign @rlenferink

@DanyC97
Copy link
Contributor

DanyC97 commented Apr 16, 2019

imo both are valid and so i don't think worth the change. Saying that will let the other sig-docs members to weigh in

@ptux
Copy link
Contributor Author

ptux commented Apr 16, 2019

It confuses me who is a non English native user.

@rlenferink
Copy link
Member

(non-native English speaker over as well). Imo both are valid, but for me the old sentence is the easiest to read.

Lets ask @Bradamant3 for input ;)

/assign @Bradamant3
as PR wrangler

@Bradamant3
Copy link
Contributor

Strictly speaking the original is preferable; the change is more formal and less common in American English at least (which has for better or worse become a standard reference point). That said, comments from non-native speakers are our best data and feedback. Adding one more fix to clear up for I hope everybody (native and non-native speakers), and changing a couple of other headings so that we maintain parallelism.

@Bradamant3
Copy link
Contributor

@ptux thanks for noticing -- the eventual fix is a bit different from what you proposed, but it's an excellent catch overall.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit f36ac6c into kubernetes:master Apr 19, 2019
@ptux
Copy link
Contributor Author

ptux commented Apr 20, 2019

@Bradamant3

Thank you for your consideration to non-native speakers.

@ptux ptux deleted the patch-2 branch April 20, 2019 06:20
nowjean pushed a commit to nowjean/website that referenced this pull request Jun 13, 2019
* fix a word order issue

* Normalize heading language
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants