Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

an offense against the style guide. #13837

Merged
merged 1 commit into from
Apr 19, 2019
Merged

an offense against the style guide. #13837

merged 1 commit into from
Apr 19, 2019

Conversation

ptux
Copy link
Contributor

@ptux ptux commented Apr 16, 2019 •
edited
Loading

Evidence:

Use code style for object field names

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 16, 2019
@ptux
Copy link
Contributor Author

ptux commented Apr 16, 2019

/assign @stewart-yu

@netlify
Copy link

netlify bot commented Apr 16, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a8dcf49

https://deploy-preview-13837--kubernetes-io-master-staging.netlify.com

@ptux
Copy link
Contributor Author

ptux commented Apr 19, 2019

This is just a friendly reminder.

@Bradamant3
Copy link
Contributor

@ptux please be patient. Reviewers get to PRs as they can, and often wait for the PR wrangler to handle small changes. Pinging us or adding vague comments won't make things move faster.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 47b7de5 into kubernetes:master Apr 19, 2019
@ptux
Copy link
Contributor Author

ptux commented Apr 20, 2019

@Bradamant3

Thank you for your review and advice.

I should be patient and I will be.

@ptux ptux deleted the patch-3 branch April 20, 2019 06:24
nowjean pushed a commit to nowjean/website that referenced this pull request Jun 13, 2019
@ptux @nowjean
an offense against the style guide. (kubernetes#13837)
668ef68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@Bradamant3 Bradamant3

@stewart-yu stewart-yu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ptux @Bradamant3 @k8s-ci-robot @stewart-yu