Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update device-plugins.md #13849

Merged
merged 1 commit into from
May 13, 2019
Merged

Update device-plugins.md #13849

merged 1 commit into from
May 13, 2019

Conversation

xuhz
Copy link
Contributor

@xuhz xuhz commented Apr 16, 2019

add link to Xilinx FPGA device plugin

add link to Xilinx FPGA device plugin
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 16, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 16, 2019
@netlify
Copy link

netlify bot commented Apr 16, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c00b406

https://deploy-preview-13849--kubernetes-io-master-staging.netlify.com

@jaredbhatti
Copy link
Contributor

Please sign the CLA

@xuhz
Copy link
Contributor Author

xuhz commented May 1, 2019

Our company(Xilinx) has e-signed the CLA.
Will the CLA check be passed automatically or anything else from my side required?

@bradtopol
Copy link
Contributor

/assign

@bradtopol
Copy link
Contributor

@xuhz Thank you for your contribution. Please sign the CLA so we can accept your PR for review.

@Rajakavitha1
Copy link
Contributor

/check-cla

@Rajakavitha1
Copy link
Contributor

@xuhz Thanks for your PR. Please see: https://github.com/kubernetes/community/blob/master/CLA.md#how-do-i-sign for instructions in case your company has already signed a CLA.

@xuhz
Copy link
Contributor Author

xuhz commented May 6, 2019

I assigned it (actually Xilinx signed it) already

Username First Name Last Name E-mail Roles Member since  
songc-xil Chuck Song [email protected] organization manager 2 weeks 5 days ago edit remove
xuhz Brian Xu [email protected] organization manager 2 weeks 5 days ago edit remove

@Rajakavitha1
Copy link
Contributor

Rajakavitha1 commented May 7, 2019

I assigned it (actually Xilinx signed it) already

Username First Name Last Name E-mail Roles Member since  
songc-xil Chuck Song [email protected] organization manager 2 weeks 5 days ago edit remove
xuhz Brian Xu [email protected] organization manager 2 weeks 5 days ago edit remove

Can you please check if you received an email https://github.com/kubernetes/community/blob/master/CLA.md#5-look-for-an-email-indicating-successful-signup if not I suggest you check: https://github.com/kubernetes/community/blob/master/CLA.md#troubleshooting

@xuhz
Copy link
Contributor Author

xuhz commented May 7, 2019

I think I know what the issue is.
I tried to sign the CLA twice -- In the first one, I assigned myself as the signer on behalf of our company, then I figured out I couldn't that. Then in the second one, our VP e-signed on behalf of the company and I was assigned as one of the manager to manage the group.

I can't delete the first one -- which is still pending and should be deleted. That's why you think I still need to e-sign the CLA.

How to delete the first one?

First Name:
Brian
Last Name:
Xu
Full Name:
Brian Xu
Groups:
CNCF - Xilinx Inc.
CNCF - Xilinx Inc
History
Site user for
3 weeks 21 min

@Rajakavitha1
Copy link
Contributor

I think I know what the issue is.
I tried to sign the CLA twice -- In the first one, I assigned myself as the signer on behalf of our company, then I figured out I couldn't that. Then in the second one, our VP e-signed on behalf of the company and I was assigned as one of the manager to manage the group.

I can't delete the first one -- which is still pending and should be deleted. That's why you think I still need to e-sign the CLA.

How to delete the first one?

First Name:
Brian
Last Name:
Xu
Full Name:
Brian Xu
Groups:
CNCF - Xilinx Inc.
CNCF - Xilinx Inc
History
Site user for
3 weeks 21 min

Thank you @xuhz !!!
Could you please log an issue here: https://sso.linuxfoundation.org/login?state=g6Fo2SBpeFNJYUlLcHp0X3NMOURkWG5WSWROWGlCRDFrd2Z4aaN0aWTZIDBaVk1IRVpZR2RiVjdlakEyY2J3X1F3Q2xINkNFM25to2NpZNkgNE1iTWxDcFhvb0RvTlEwMlRvUXY5eXB3Tk96aWY1MTY&client=4MbMlCpXooDoNQ02ToQv9ypwNOzif516&protocol=samlp

If you encounter any problems signing the CLA, log a ticket with the Linux Foundation ID group through the Linux Foundation Support Site.

Should you have any issues using the LF Support Site, send a message to the backup e-mail support address [email protected]

Someone from the CNCF will respond to your ticket to help.

@xuhz
Copy link
Contributor Author

xuhz commented May 9, 2019

The e-sign takes effect now.
Please recheck it,
thanks!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 9, 2019
@sftim
Copy link
Contributor

sftim commented May 13, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2019
@Rajakavitha1
Copy link
Contributor

Thanks for your PR @xuhz!!!!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit a05ab94 into kubernetes:master May 13, 2019
yoonian pushed a commit to yoonian/kubernetes-website that referenced this pull request May 28, 2019
add link to Xilinx FPGA device plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants