Translate concepts/overview/working-with-objects/annotations in Korean #14115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/M
|
Deploy preview for k8s-dev-ko ready! Built with commit fa8b243 |
|
/assign @seokho-son |
seokho-son
reviewed
May 2, 2019
There was a problem hiding this comment.
@uncle-elephant 님. 컨트리뷰션 감사합니다 !! 👍
리뷰 의견 남겼습니다. 업데이트에 참고하시기 바랍니다.
content/ko/docs/concepts/overview/working-with-objects/annotations.md
Outdated
Show resolved
Hide resolved
content/ko/docs/concepts/overview/working-with-objects/annotations.md
Outdated
Show resolved
Hide resolved
content/ko/docs/concepts/overview/working-with-objects/annotations.md
Outdated
Show resolved
Hide resolved
content/ko/docs/concepts/overview/working-with-objects/annotations.md
Outdated
Show resolved
Hide resolved
content/ko/docs/concepts/overview/working-with-objects/annotations.md
Outdated
Show resolved
Hide resolved
content/ko/docs/concepts/overview/working-with-objects/annotations.md
Outdated
Show resolved
Hide resolved
content/ko/docs/concepts/overview/working-with-objects/annotations.md
Outdated
Show resolved
Hide resolved
content/ko/docs/concepts/overview/working-with-objects/annotations.md
Outdated
Show resolved
Hide resolved
content/ko/docs/concepts/overview/working-with-objects/annotations.md
Outdated
Show resolved
Hide resolved
리뷰 감사합니다. 반영했습니다. :) |
@uncle-elephant Thank you ! It looks good to me. |
|
@uncle-elephant Thank you so much for the contribution. 👍 @seokho-son Thanks for providing reviews and guidance. /assign |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ClaudiaJKang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
claudiajkang
pushed a commit
that referenced
this pull request
May 7, 2019
* Fixed the ko-typo (#13983) * ko: Update outdated files in dev-1.14-ko.3 (#14055) * Translate concepts/overview/working-with-objects/annotations in Korean (#14115) Co-authored-by: Chirag Shah <[email protected]> Co-authored-by: June Yi <[email protected]> Co-authored-by: Claudia J. Kang <[email protected]> Co-authored-by: uncle-elephant <[email protected]> Co-authored-by: Seokho <[email protected]>
k8s-ci-robot
pushed a commit
that referenced
this pull request
May 7, 2019
* Fixed the ko-typo (#13983) * ko: Update outdated files in dev-1.14-ko.3 (#14055) * Translate concepts/overview/working-with-objects/annotations in Korean (#14115) Co-authored-by: Chirag Shah <[email protected]> Co-authored-by: June Yi <[email protected]> Co-authored-by: Claudia J. Kang <[email protected]> Co-authored-by: uncle-elephant <[email protected]> Co-authored-by: Seokho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #13647