Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add related note with pod deleted #14709

Merged
merged 3 commits into from
Jun 11, 2019
Merged

add related note with pod deleted #14709

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f64a0e
feat: add job application has some error and restartPolicy is not Ner…
fudali113 Jun 4, 2019
5122b6b
feat: optimize delete pods related suggestion
fudali113 Jun 10, 2019
c230d06
Update jobs-run-to-completion.md
tengqm Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions content/en/docs/concepts/workloads/controllers/jobs-run-to-completion.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,12 @@ status check.
{{< note >}}
Issue [#54870](https://github.com/kubernetes/kubernetes/issues/54870) still exists for versions of Kubernetes prior to version 1.12
{{< /note >}}
{{< note >}}
If your job has `restartPolicy = "OnFailure"`, keep in mind that your container running the Job
will be terminated once the job backoff limit has been reached. This can make debugging the Job's executable more difficult. We suggest setting
`restartPolicy = "Never"` when debugging the Job or using a logging system to ensure output
from failed Jobs is not lost inadvertently.`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a stray "`" character at the end of this line which needs deleting please.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch. fixed it by copyediting.

{{< /note >}}

## Job Termination and Cleanup

Expand Down