Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --show-labels #14779

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Added --show-labels #14779

merged 2 commits into from
Jun 18, 2019

Conversation

dpandhi-git
Copy link
Contributor

@dpandhi-git dpandhi-git commented Jun 7, 2019

Added --show-labels as per #14778

@k8s-ci-robot
Copy link
Contributor

Welcome @dpandhi-git!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 7, 2019
@netlify
Copy link

netlify bot commented Jun 7, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit cd3186a

https://deploy-preview-14779--kubernetes-io-master-staging.netlify.com

@dpandhi-git dpandhi-git changed the title fix #14778 Added --show-labels Jun 7, 2019
@hpandeycodeit
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2019
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Jun 7, 2019
@tengqm
Copy link
Contributor

tengqm commented Jun 10, 2019

The 'OR' added inside a code snippet is breaking the flow.

Copy link

@hpandeycodeit hpandeycodeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpandhi-git This "OR" can be put in comments as it is not an actual command.

content/en/docs/reference/kubectl/cheatsheet.md Outdated Show resolved Hide resolved
@hpandeycodeit
Copy link

Thanks @dpandhi-git!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2019
@hpandeycodeit
Copy link

hpandeycodeit commented Jun 12, 2019

for item in $( kubectl get pod --output=name);
 do printf "Labels for %s\n" "$item"
 | grep --color -E '[^/]+$' && kubectl get "$item" --output=json
 | jq -r -S '.metadata.labels | to_entries
 | .[] | " \(.key)=\(.value)"' 2>/dev/null; printf "\n"; done

The above script uses jq command and this needs to be installed in order to run this script successfully.

kubectl get pods --show-labels does that job in one line.

So I think the above script can be removed.

@steveperry-53
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveperry-53

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 658f5c4 into kubernetes:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants