-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview changes to controller documentation #15373
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit aa61856 https://deploy-preview-15373--kubernetes-io-master-staging.netlify.com |
|
||
In applications of robotics and automation, a _control loop_ is | ||
a non-terminating loop that regulates the state of the system. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @sftim .
This is a good start to the Controller overview. I think this page is fairly important. This page could be treated as a separate PR to kick off the other controller additions/changes. Get tech review for this page.
Here are a few ideas/questions I have about What is a Controller?
:
- How does the first sentence tie in to the k8s controller concept (the second sentence)?
- What is a built-in controller? How does a built-in controller differ from a custom controller?
- Are the controllers executors as well as state maintainers?
- What happens if a controller fails? Is the controller restarted?
- The Controller pattern mentions
well-implemented
, but does not say how to implement one - Add a
What's next
section to tie in additional controller resources, such askubebuilder
? - Clients of controllers?
e80d783
to
aa61856
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sftim: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sftim I'd love to see this move forward. Please feel free to /close |
@zacharysarah: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is related to issue #4135 about a concept-level guide to controllers.
This PR isn't here to be merged. Instead, I'm pushing it up as a way to let people see the set of changes I've got on mind all in one place.
Based on the work I've done here, I plan to carve off smaller chunks that are easier to review, and PR those in turn.
For feedback:
/hold not-for-merging