Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change link to official CloudStack cloud provider #15509

Closed
wants to merge 1 commit into from

Conversation

onitake
Copy link

@onitake onitake commented Jul 23, 2019

Fixes #14817

The Kubernetes has incorrectly referred to the OpenStack cloud provider as suitable for CloudStack for quite some time.

As the CloudStack developers have now started to work on an official cloud provider, the docs should link to this provider instead.

@k8s-ci-robot
Copy link
Contributor

Welcome @onitake!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bradamant3
You can assign the PR to them by writing /assign @bradamant3 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 23, 2019
@onitake
Copy link
Author

onitake commented Jul 23, 2019

@rhtyd FYI

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Jul 23, 2019

Thanks @onitake - let's work to get the codebase/PR in soon into the apache/cloudstack-kubernetes-provider repo.

@zacharysarah
Copy link
Contributor

@onitake 👋 Please feel free to /reopen when you're ready to continue.

/close

@k8s-ci-robot
Copy link
Contributor

@zacharysarah: Closed this PR.

In response to this:

@onitake 👋 Please feel free to /reopen when you're ready to continue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rohityadavcloud
Copy link
Member

@onitake the repo can accept your PR as soon as one remark is addressed and therefore the website change: https://github.com/apache/cloudstack-kubernetes-provider

@onitake
Copy link
Author

onitake commented Sep 20, 2019

Code transfer to the Apache foundation is finished.
There's still some plumbing work to be done, move CI etc.
I'll reopen once I get the ok from @rhtyd .

@onitake onitake changed the title [WIP] [DONOTMERGE] Change link to official CloudStack cloud provider Change link to official CloudStack cloud provider Sep 20, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2019
@onitake
Copy link
Author

onitake commented Oct 1, 2019

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Oct 1, 2019
@k8s-ci-robot
Copy link
Contributor

@onitake: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@onitake
Copy link
Author

onitake commented Oct 1, 2019

I think we're ready to go ahead with the documentation update now.
There isn't a first official release yet, but the code is in place and the the k8s documentation is still wrong (pointing to the OpenStack provider).

@onitake
Copy link
Author

onitake commented Oct 1, 2019

This was already fixed in master by #16129 and can be closed.

@onitake onitake closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants