Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate docs/tasks/tools/install-minikube/ in Japanese #15729

Closed
wants to merge 16 commits into from

Conversation

kaedemalu
Copy link

@kaedemalu kaedemalu commented Aug 8, 2019

Close #13379

oke-py and others added 15 commits March 13, 2019 19:22
* ja-trans: update expose-intro.html

* ja-trans: fix broken links by linking to english pages
* update deploy-intro.html (kubernetes#13103)

* Update content/ja/docs/tutorials/kubernetes-basics/deploy-app/deploy-intro.html

add /ja path

Co-Authored-By: chidakiyo <[email protected]>
)

* ja-trans: update /ja/docs/tutorials/kubernetes-basics/

* ja-trans: translate card.title
* [ja] Update content of setup/minikube.md, fixing the diff between 551489f 7b07d19.

* [ja] Translate the content: content/ja/docs/setup/minikube.md (kubernetes#13091)

* Correct Katakana words, using long vowel words

Co-Authored-By: yukinagae <[email protected]>

* Fix typos

Co-Authored-By: yukinagae <[email protected]>

* Correct some changes, thanks for the FB

Co-Authored-By: yukinagae <[email protected]>
…s#13094) (kubernetes#13328)

* ja-trans: Update the content of setup/pick-right-solution.md, only fixing the diff between 551489f and 7b07d19.
(Not yet translating the content at the moment to only make sure fixing the diff is ok. Next commit will be actually the translation stuff)

* ja-trans: Translate /ja/docs/setup/pick-right-solution.md (kubernetes#13094)

* Update content/ja/docs/setup/pick-right-solution.md

Correct small changes based on the feedback

Co-Authored-By: yukinagae <[email protected]>

* Better translation and refer the Japanese document link

Co-Authored-By: yukinagae <[email protected]>

* Correct Japanese anchors

Co-Authored-By: yukinagae <[email protected]>

* Correct translation mistakes

Co-Authored-By: yukinagae <[email protected]>
* follow to the latest format

* review
* format

* Update content/ja/docs/setup/certificates.md

Co-Authored-By: inductor <[email protected]>
@k8s-ci-robot
Copy link
Contributor

Welcome @kaedemalu!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 8, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 8, 2019
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 8, 2019
@inductor
Copy link
Member

inductor commented Aug 8, 2019

@kaedemalu こんにちは。
Kubernetesドキュメントのコントリビュートありがとうございます!
以下の4つについて修正をお願いできますでしょうか?

  1. PRテンプレートのデフォルトの文章は Remember to delete this note before submitting your pull request. とありますので消していただけますと幸いです!

  2. Issueのマイルストーンのベースブランチが違うので 1.14-ja.2 に直してほしいです!

  3. KubernetesプロジェクトへのコントリビュートにはCloud Native Computing FoundationのCLAというものに署名して頂く必要があります。botのコメントに従い、本PRのラベルが cncf-cla: yes になるように対応をお願いします 🙏

  4. 2の対応で治れば問題ないのですが、不要な差分がいくつかあるようなので、Rebaseするなりして必要な差分だけにしていただけますでしょうか。

@kaedemalu kaedemalu changed the base branch from dev-1.14-ja.1 to dev-1.14-ja.2 August 8, 2019 01:55
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2019
@nasa9084
Copy link
Member

nasa9084 commented Aug 9, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2019
Copy link
Member

@inductor inductor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ以外にもいっぱい差分でてるので、rebaseお願いしますね

@@ -2,6 +2,9 @@
title: Kubernetesとは何か?
content_template: templates/concept
weight: 10
card:
name: concepts
weight: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この差分は不要

display_browse_numbers: true
cid: docsHome
layout: docsportal_home
class: gridPage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここもいらない

@@ -14,7 +14,7 @@ This page explains the certificates that your cluster requires.

{{% capture body %}}

## あなたのクラスタではどのように証明書が使われているのか
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なぜここで差分が

@kaedemalu
Copy link
Author

@inductor
dev-1.14-ja.2 にrebaseします

@inductor
Copy link
Member

inductor commented Aug 9, 2019

Kubernetes Slackのドキュメント翻訳チャンネルでもいつでも相談受け付けてます〜〜

@inductor
Copy link
Member

inductor commented Aug 9, 2019

Descriptionのところに、どのIssueに対するPRなのかを明記しておいてください!
#15638 などを参考に。

@kaedemalu kaedemalu changed the title Dev 1.14 ja.1 Translate docs/tasks/tools/install-minikube/ in Japanese #13379 Aug 9, 2019
@kaedemalu kaedemalu changed the title Translate docs/tasks/tools/install-minikube/ in Japanese #13379 Translate docs/tasks/tools/install-minikube/ in Japanese Aug 9, 2019
@inductor
Copy link
Member

inductor commented Aug 9, 2019

KubernetesプロジェクトへのコントリビュートにはCloud Native Computing FoundationのCLAというものに署名して頂く必要があります。botのコメントに従い、本PRのラベルが cncf-cla: yes になるように対応をお願いします 🙏

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign nasa9084
You can assign the PR to them by writing /assign @nasa9084 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 16, 2019
@kaedemalu kaedemalu force-pushed the dev-1.14-ja.1 branch 3 times, most recently from 58a63b1 to 9cd53a9 Compare August 16, 2019 23:37
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 20, 2019
@nasa9084
Copy link
Member

/label needs-rebase
rebase先間違ってそう

@nasa9084
Copy link
Member

あ、needs-rebaseはlabelコマンドじゃつけれないのか
/hold

@inductor
Copy link
Member

一応昨日会って話して、一回これベースブランチ切り直してcherry-pickしたほうが楽なんじゃね?という話をした

@nasa9084
Copy link
Member

それでもよいです〜

@kaedemalu
Copy link
Author

#16025

こちらに作り直しました

@nasa9084
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@nasa9084: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants