-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate docs/tasks/tools/install-minikube/ in Japanese #15729
Conversation
* ja-trans: update expose-intro.html * ja-trans: fix broken links by linking to english pages
* update deploy-intro.html (kubernetes#13103) * Update content/ja/docs/tutorials/kubernetes-basics/deploy-app/deploy-intro.html add /ja path Co-Authored-By: chidakiyo <[email protected]>
* [ja] Update content of setup/minikube.md, fixing the diff between 551489f 7b07d19. * [ja] Translate the content: content/ja/docs/setup/minikube.md (kubernetes#13091) * Correct Katakana words, using long vowel words Co-Authored-By: yukinagae <[email protected]> * Fix typos Co-Authored-By: yukinagae <[email protected]> * Correct some changes, thanks for the FB Co-Authored-By: yukinagae <[email protected]>
…s#13094) (kubernetes#13328) * ja-trans: Update the content of setup/pick-right-solution.md, only fixing the diff between 551489f and 7b07d19. (Not yet translating the content at the moment to only make sure fixing the diff is ok. Next commit will be actually the translation stuff) * ja-trans: Translate /ja/docs/setup/pick-right-solution.md (kubernetes#13094) * Update content/ja/docs/setup/pick-right-solution.md Correct small changes based on the feedback Co-Authored-By: yukinagae <[email protected]> * Better translation and refer the Japanese document link Co-Authored-By: yukinagae <[email protected]> * Correct Japanese anchors Co-Authored-By: yukinagae <[email protected]> * Correct translation mistakes Co-Authored-By: yukinagae <[email protected]>
* follow to the latest format * review
* format * Update content/ja/docs/setup/certificates.md Co-Authored-By: inductor <[email protected]>
Welcome @kaedemalu! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@kaedemalu こんにちは。
|
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これ以外にもいっぱい差分でてるので、rebaseお願いしますね
@@ -2,6 +2,9 @@ | |||
title: Kubernetesとは何か? | |||
content_template: templates/concept | |||
weight: 10 | |||
card: | |||
name: concepts | |||
weight: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この差分は不要
display_browse_numbers: true | ||
cid: docsHome | ||
layout: docsportal_home | ||
class: gridPage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここもいらない
@@ -14,7 +14,7 @@ This page explains the certificates that your cluster requires. | |||
|
|||
{{% capture body %}} | |||
|
|||
## あなたのクラスタではどのように証明書が使われているのか |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なぜここで差分が
@inductor |
Kubernetes Slackのドキュメント翻訳チャンネルでもいつでも相談受け付けてます〜〜 |
Descriptionのところに、どのIssueに対するPRなのかを明記しておいてください! |
|
7bbee3f
to
a8b2bb3
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a8b2bb3
to
b1b18ca
Compare
58a63b1
to
9cd53a9
Compare
I signed it
9cd53a9
to
da0cfba
Compare
/label needs-rebase |
あ、needs-rebaseはlabelコマンドじゃつけれないのか |
一応昨日会って話して、一回これベースブランチ切り直してcherry-pickしたほうが楽なんじゃね?という話をした |
それでもよいです〜 |
こちらに作り直しました |
/close |
@nasa9084: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Close #13379