Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation for proxies and controller metrics #15746

Merged
merged 11 commits into from
Aug 12, 2019

Conversation

mkorbi
Copy link
Contributor

@mkorbi mkorbi commented Aug 8, 2019

content/de/docs/concepts/cluster-administration/proxies.md
content/de/docs/concepts/cluster-administration/controller-metrics.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2019
@k8s-ci-robot k8s-ci-robot added language/de Issues or PRs related to German language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 8, 2019
@rlenferink rlenferink changed the title German I18n for two shorter pages German translation for proxies and controller metrics Aug 8, 2019
@rlenferink
Copy link
Member

@mkorbi For some reason the CCM translation is included as well (PR #15727). Can you rebase and drop that commit?

@netlify
Copy link

netlify bot commented Aug 8, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1dd5f8c

https://deploy-preview-15746--kubernetes-io-master-staging.netlify.com

Copy link
Member

@rlenferink rlenferink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I'll leave approval to @bene2k1 as native German speaker

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2019
@bene2k1
Copy link
Member

bene2k1 commented Aug 12, 2019

lgtm

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bene2k1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 16ae99f into kubernetes:master Aug 12, 2019
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
* i18n cloud controller

* add controller metrics

* 2nd check on controller metrics

* add proxies

* check proxies

* add controller metrics

* 2nd check on controller metrics

* add proxies

* check proxies

* Revert "Merge branch 'i18n-003' of github.com:mkorbi/website into i18n-003"

This reverts commit 76bf403.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants