Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bootstrap js ref to 4.3.1 for API v1.15 #16263

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

ahlinc
Copy link
Contributor

@ahlinc ahlinc commented Sep 9, 2019

A fix for the v1.15 API version was missed in the #14775 PR
because the dev-1.15 branch was forked from the master branch
before the fix and has been merged back to the master after it.

@k8s-ci-robot
Copy link
Contributor

Welcome @ahlinc!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 9, 2019
@ahlinc ahlinc marked this pull request as ready for review September 9, 2019 10:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2019
@netlify
Copy link

netlify bot commented Sep 9, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ce039e7

https://deploy-preview-16263--kubernetes-io-master-staging.netlify.com

A fix for the v1.15 API version was missed in the kubernetes#14775 PR
because the dev-1.15 branch was forked from the master branch
before the fix and has been merged back to the master after it.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 9, 2019
@ahlinc
Copy link
Contributor Author

ahlinc commented Sep 10, 2019

/assign @tfogo

@ahlinc
Copy link
Contributor Author

ahlinc commented Sep 10, 2019

/cc @Bradamant3 @jimangel @kbarnard10 @pwittrock @steveperry-53 @tengqm @zacharysarah @zparnold Could someone review, merge and deploy this fix because it's related to the API reference for the latest v1.15 k8s version and fixes broken example buttons on the API page?
Thanks.

@zacharysarah
Copy link
Contributor

@ahlinc 👋 Thanks for this fix. This page is the downstream result of an upstream process; so if you only fix it here, changes will be overwritten the next time we generate the reference.

Please work with @tengqm and @aimeeu to find the correct location for the upstream source fix.

@ahlinc
Copy link
Contributor Author

ahlinc commented Sep 10, 2019

@zacharysarah thank you for looking to this PR. As I found upstream already is totally fine and only this specific already generated page requires direct fix in the same way as it was done in mentioned #14775 PR. Please correct me if I'm wrong, as I found version specific API references placed in a static/docs/reference/generated/kubernetes-api folder are stored in pregenerated form so there is no impact on them from upstream changes and the generation process just copies versioned API reference folders from a static/ into a public/ folder as is without any changes in the same way like when we run make docker-build locally.

@zacharysarah
Copy link
Contributor

@ahlinc Sounds good to me. Thanks for the explanation.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6533b7f into kubernetes:master Sep 10, 2019
@ahlinc
Copy link
Contributor Author

ahlinc commented Sep 11, 2019

@zacharysarah Awesome, thank you, now the page works correctly.

wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 18, 2019
A fix for the v1.15 API version was missed in the kubernetes#14775 PR
because the dev-1.15 branch was forked from the master branch
before the fix and has been merged back to the master after it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants