-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init Russian localization #16404
Init Russian localization #16404
Conversation
Co-Authored-By: Tim Bannister <[email protected]>
…into msheldyakov-language_ru
… into dianaabv-russ-localization
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@Potapy4 Is this PR still a work in progress? If it's ready for review, please |
yep, it's ready for review 🙂 |
Did people want to look at tweaks for https://github.com/kubernetes/website/pull/16404/files#diff-e8a2af53a84007f16a69bd8df94296efR152 and other English lines in this file? Iif not: I would leave as is, merge as is, and log an insta-frozen cleanup issue to track the work. Tracking that work helps make sure it isn't forgotten. |
@sftim I translated the remaining strings ✔️ |
There are no remaining English sentences as far as I can see. @zacharysarah Could we merge this PR and add another language 🇷🇺 ? 😄 |
This PR needs more work before it can merge. It looks like netlify is failing:
|
|
||
{{< blocks/section id="oceanNodes" >}} | ||
{{% blocks/feature image="flower" %}} | ||
### [Kubernetes (K8s)]({{< relref "/docs/concepts/overview/what-is-kubernetes" >}}) - это открытое программное обеспечение для автоматизации развёртывания, масштабирования и управления контейнеризированными приложениями. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that netlify is failing because of the shortcode in this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to review 👀
This looks ready to merge. Поздравляю! 🎉 /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/language ru |
* [DaemonSet](/docs/concepts/workloads/controllers/daemonset/) | ||
* [StatefulSet](/docs/concepts/workloads/controllers/statefulset/) | ||
* [ReplicaSet](/docs/concepts/workloads/controllers/replicaset/) | ||
* [Задачи](/docs/concepts/workloads/controllers/jobs-run-to-completion/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Возможно, что стоило оставить названия объектов как есть -- Deployment, Job. Аналогично и выше -- Pod, Service, Volume, Namespace, так как пользователям все равно придется их увидеть на английском в примерах манифестов.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@php-coder хм, скорее всего, да, в данном случае не стоит их переводить. Отправите PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Сделал: #18613
"Том" оставил как есть потому что это как бы общее название. Как вариант, можно было использовать PersistentVolume.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут имеется в виду абстракции в коде (верно?), поэтому тогда и том может по англ. написать?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Смысл моей правки был в том, чтобы оставить названия kind-ов оригинальными, чтобы подчеркнуть что это их названия. В случае с томами, такой сущности в API нет -- есть PersistentVolume
Ссылка указывает на страницу https://kubernetes.io/docs/concepts/storage/volumes/ где рассказывается о томах которые можно примонтировать к поду -- это не отдельные сущности (kind), поэтому для них и используется обобщенное название.
Надеюсь, что у меня получилось донести свою мысль :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Оно! Отлично, вот и я узнал что-то новенькое :)
Спасибо!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Мне кажется они имели в виду сами объекты из внутренностей, а не для конечного пользователя, хотя они совпадают зачастую. В общем, я бы поменял, всё равно на странице будет именно "том" использоваться.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Да, но с кодом пользователь вряд ли сталкнется, а вот с API сущностями -- весьма вероятно.
Кстати, я не настаиваю -- если считаете, что надо и это слово перевести, предложите правку в мой PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Да я сам в сомнениях, вроде говорится про основные объекты, значит мы не должны их переводить, а писать как есть, а с другой стороны Volume как такого нет для пользователя 💭
Since at different times people started a new russian translation (see PR #16003 and #16378) - we discussed and decided to merge them into one branch to create one PR.
/cc: @dianaabv, @msheldyakov, @aisonaku