Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init Russian localization #16404

Merged
merged 35 commits into from
Nov 14, 2019
Merged

Init Russian localization #16404

merged 35 commits into from
Nov 14, 2019

Conversation

Potapy4
Copy link
Contributor

@Potapy4 Potapy4 commented Sep 17, 2019

Since at different times people started a new russian translation (see PR #16003 and #16378) - we discussed and decided to merge them into one branch to create one PR.

/cc: @dianaabv, @msheldyakov, @aisonaku

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 17, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zacharysarah
Copy link
Contributor

zacharysarah commented Oct 29, 2019

@Potapy4 Is this PR still a work in progress? If it's ready for review, please /retitle the PR to remove "WIP". Thanks in advance!

@Potapy4 Potapy4 changed the title WIP: Init Russian localization Init Russian localization Oct 30, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2019
@Potapy4
Copy link
Contributor Author

Potapy4 commented Oct 30, 2019

@Potapy4 Is this PR still a work in progress? If it's ready for review, please /retitle the PR to remove "WIP". Thanks in advance!

yep, it's ready for review 🙂

@sftim
Copy link
Contributor

sftim commented Nov 8, 2019

Did people want to look at tweaks for https://github.com/kubernetes/website/pull/16404/files#diff-e8a2af53a84007f16a69bd8df94296efR152 and other English lines in this file?

Iif not: I would leave as is, merge as is, and log an insta-frozen cleanup issue to track the work. Tracking that work helps make sure it isn't forgotten.

@lex111
Copy link
Contributor

lex111 commented Nov 8, 2019

@sftim I translated the remaining strings ✔️
We can merge this PR?

@remyleone
Copy link
Contributor

There are no remaining English sentences as far as I can see. @zacharysarah Could we merge this PR and add another language 🇷🇺 ? 😄

@zacharysarah
Copy link
Contributor

zacharysarah commented Nov 13, 2019

This PR needs more work before it can merge. It looks like netlify is failing:

2:13:22 AM: ERROR 2019/11/08 10:13:22 [ru] REF_NOT_FOUND: Ref "/docs/concepts/overview/what-is-kubernetes": "/opt/build/repo/content/ru/_index.html:1:1": page not found


{{< blocks/section id="oceanNodes" >}}
{{% blocks/feature image="flower" %}}
### [Kubernetes (K8s)]({{< relref "/docs/concepts/overview/what-is-kubernetes" >}}) - это открытое программное обеспечение для автоматизации развёртывания, масштабирования и управления контейнеризированными приложениями.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that netlify is failing because of the shortcode in this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to review 👀

@zacharysarah
Copy link
Contributor

This looks ready to merge.

Поздравляю! 🎉
@Potapy4 @lex111 @dianaabv @msheldyakov @aisonaku @remyleone

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9d0cc29 into kubernetes:master Nov 14, 2019
@sftim
Copy link
Contributor

sftim commented Jan 2, 2020

/language ru

@k8s-ci-robot k8s-ci-robot added the language/ru Issues or PRs related to Russian language label Jan 2, 2020
* [DaemonSet](/docs/concepts/workloads/controllers/daemonset/)
* [StatefulSet](/docs/concepts/workloads/controllers/statefulset/)
* [ReplicaSet](/docs/concepts/workloads/controllers/replicaset/)
* [Задачи](/docs/concepts/workloads/controllers/jobs-run-to-completion/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Возможно, что стоило оставить названия объектов как есть -- Deployment, Job. Аналогично и выше -- Pod, Service, Volume, Namespace, так как пользователям все равно придется их увидеть на английском в примерах манифестов.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@php-coder хм, скорее всего, да, в данном случае не стоит их переводить. Отправите PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сделал: #18613

"Том" оставил как есть потому что это как бы общее название. Как вариант, можно было использовать PersistentVolume.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут имеется в виду абстракции в коде (верно?), поэтому тогда и том может по англ. написать?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Смысл моей правки был в том, чтобы оставить названия kind-ов оригинальными, чтобы подчеркнуть что это их названия. В случае с томами, такой сущности в API нет -- есть PersistentVolume

Ссылка указывает на страницу https://kubernetes.io/docs/concepts/storage/volumes/ где рассказывается о томах которые можно примонтировать к поду -- это не отдельные сущности (kind), поэтому для них и используется обобщенное название.

Надеюсь, что у меня получилось донести свою мысль :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Оно! Отлично, вот и я узнал что-то новенькое :)

Спасибо!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне кажется они имели в виду сами объекты из внутренностей, а не для конечного пользователя, хотя они совпадают зачастую. В общем, я бы поменял, всё равно на странице будет именно "том" использоваться.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, но с кодом пользователь вряд ли сталкнется, а вот с API сущностями -- весьма вероятно.

Кстати, я не настаиваю -- если считаете, что надо и это слово перевести, предложите правку в мой PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да я сам в сомнениях, вроде говорится про основные объекты, значит мы не должны их переводить, а писать как есть, а с другой стороны Volume как такого нет для пользователя 💭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ru Issues or PRs related to Russian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.