Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links #16637

Closed
wants to merge 1 commit into from
Closed

Broken links #16637

wants to merge 1 commit into from

Conversation

butuzov
Copy link
Contributor

@butuzov butuzov commented Oct 1, 2019

This fix resolve

  • broken links in documentation (Indonesian and Korean)
  • misplaced markdown braces (that was generated web errors)
  • fix a few links in the blog (English)

This fix resolve
- broken links in documentation (Indonesian and Korean)
- misplaced markdown braces (that was generated web errors)
- fix a few links in blog (english)
@k8s-ci-robot
Copy link
Contributor

Welcome @butuzov!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zacharysarah
You can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language language/id Issues or PRs related to Indonesian language language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 1, 2019
@butuzov
Copy link
Contributor Author

butuzov commented Oct 1, 2019

It will be great to have "hacktoberfest" labels =)

@netlify
Copy link

netlify bot commented Oct 1, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e457f2a

https://deploy-preview-16637--kubernetes-io-master-staging.netlify.com

@sftim
Copy link
Contributor

sftim commented Oct 1, 2019

Hi @butuzov

Thanks for submitting this.

This pull request touches several different parts of the website. Would you be willing to resubmit this as different pull requests?
Typically: a change to the blog posts would be separate from non-blog changes, and each pull request should only cover a single localization (eg Bahasa Indonesia).

@irvifa
Copy link
Member

irvifa commented Oct 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2019
@butuzov
Copy link
Contributor Author

butuzov commented Oct 1, 2019

Hi @sftim

No problem.

Can I combine blog related changes in one PR?

@sftim
Copy link
Contributor

sftim commented Oct 1, 2019

combine blog related changes in one PR?
That should be fine!

@butuzov
Copy link
Contributor Author

butuzov commented Oct 1, 2019

It can be closed, in favor of that bunch of PRs. On other points - there are a lot of 404 at the website.. like 267 only for local links. Where can I share this info?

I rather kill myself than create an issue for each URL (which I am investigating manually)? Or should I create PR in auto mode (it shouldn't be hard using scripting).

@butuzov
Copy link
Contributor Author

butuzov commented Oct 1, 2019

/do-not-merge

@irvifa
Copy link
Member

irvifa commented Oct 1, 2019

I think this is related to #16642

@butuzov
Copy link
Contributor Author

butuzov commented Oct 1, 2019

yes! also related to

And I have no idea what to do with the rest of the broken links I have found.

image

@irvifa
Copy link
Member

irvifa commented Oct 1, 2019

Since you already selarate it into new PRs may be you can close this PR in favor of that other PRs? Cheers!

@butuzov
Copy link
Contributor Author

butuzov commented Oct 1, 2019

oh. sure.

@butuzov butuzov closed this Oct 1, 2019
@butuzov butuzov deleted the links branch October 1, 2019 11:51
@sftim
Copy link
Contributor

sftim commented Oct 1, 2019

@butuzov there are two ways you can help further (if you're interested):

  1. Log an issue about the remaining list of broken links.
  2. Take a look at automating the reporting / checking; see issue Run link checker via Prow continuous integration #15893

@butuzov
Copy link
Contributor Author

butuzov commented Oct 1, 2019

@sftim I will try to back asap, maybe with some automated aproach. at least it's nice to develop own link checking tool and test it with kubernetes website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/id Issues or PRs related to Indonesian language language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants