Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move init containers to stable in v1.6 #1939

Merged
merged 412 commits into from
Mar 22, 2017

Conversation

hodovska
Copy link

@hodovska hodovska commented Dec 13, 2016

Since init containers concept was proved in beta version in 1.4 and 1.5 it can be moved to stable in 1.6.

upstream PR: kubernetes/kubernetes#38382
trello: https://trello.com/c/Yr7TRKHr/578-5-node-promote-init-containers-to-ga


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2016
@devin-donnelly
Copy link
Contributor

@hodovska If this PR isn't relevant until the 1.6 release, it's going to sit here for a while without being merged.

@devin-donnelly devin-donnelly added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Dec 27, 2016
@@ -162,7 +157,7 @@ reasons:
## Support and compatibilty

A cluster with Kubelet and Apiserver version 1.4.0 or greater supports init
Copy link
Member

@erictune erictune Jan 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe say:

A cluster with Apiserver version 1.6.0 or greater supports init containers using the spec.initContainers field. Previous versions support init containers using the alpha or beta annotations. The spec.initContainers field is also mirrored into alpha and beta annotations so that Kubelets version 1.3.0 or greater can execute init containers, and so that a version 1.6 apiserver can safely be rolled back to version 1.5.x without losing init container function for existing created pods.

@erictune erictune self-assigned this Jan 6, 2017
@erictune
Copy link
Member

erictune commented Jan 6, 2017

Thanks @hodovska for updating this. Looks pretty good. One suggestion

@erictune erictune closed this Jan 6, 2017
@erictune erictune reopened this Jan 6, 2017
@bgrant0607 bgrant0607 removed their assignment Jan 24, 2017
@chenopis chenopis added this to the 1.6 milestone Feb 3, 2017
@chenopis
Copy link
Contributor

@hodovska FYI, the kubernetes:release-1.6 branch is now available. Please change the base branch to that. Thx

@hodovska
Copy link
Author

@erictune I rebased PR and made relevant changes, could you please review it again, since the structure changed in 1.6?

@chenopis
Copy link
Contributor

@hodovska I made some minor changes to make the docs more consistent w/ how we capitalize Container and Init Container when they are referenced as concepts instead of specific instances.

@chenopis chenopis self-assigned this Feb 15, 2017
@chenopis chenopis changed the base branch from master to release-1.6 February 17, 2017 18:38
@chenopis chenopis added Docs LGTM and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Feb 17, 2017
@chenopis
Copy link
Contributor

@erictune Ping me when you give your final LGTM. I will merge this PR then. Thx

tailnode and others added 9 commits February 24, 2017 08:18
Delete the parameter "--google-json-key string"
Ubuntu default install not include apt-transport-https. so if you want to download package from https repo, you need install apt-transport-https package first
I think it's redundant that the second to ,in order to do sth and do
sth!thanks!
fix command kubectl get svc,pod output
devin-donnelly and others added 27 commits March 21, 2017 15:31
fix the link of logging-elasticsearch-kibana.md
[UX] "View $PAGE on GitHub" without forking the repo
Added info about controller manager setup and current implementation when using PSP with RBAC support.
fix a typo in /docs/user-guide/configmap/index.md
Update manage-compute-resources-container.md
…ixing

docs/admin: document OpenID Connect plugin's claim prefixing
PSP: Added example and docu for hostPort ranges
* fix typeo

* Update kargo.md
evaluation --> evaluated
* Apply typo fixes from kubernetes#2791

* remove style typos
Signed-off-by: yupengzte <[email protected]>
…hub.io into init-cont-doc-1.6

* 'master' of https://github.com/kubernetes/kubernetes.github.io: (350 commits)
  Fix typo (kubernetes#2842)
  Fix typo
  Fix the typos
  Apply typo fixes from kubernetes#2791 (kubernetes#2949)
  Fix typo in kubectl_completion.md
  fix typeo (kubernetes#2856)
  Use kubectl config current-context to simplify the instructions
  updated PSP documentation with RBAC (kubernetes#2552)
  Create hyperlink
  Add files via upload
  Fix typo
  Remove from TOC/Search: pods/init-containers ... (kubernetes#2694)
  fix the link of ogging-elasticsearch-kibana.md
  Add files via upload
  fix to taint the master node
  Move Guide topics: Container Lifestyle Hooks, Images, Volumes
  View $PAGE on Github without forking the repo
  fix a typo in /docs/user-guide/configmap/index.md
  Fix monitor-node-health.md
  amend monitor-node-health.md
  ...

# Conflicts:
#	docs/tasks/configure-pod-container/configure-pod-initialization.md
@chenopis
Copy link
Contributor

@hodovska I merged in master and release-1.6 to bring this branch up to date. Cheers

@chenopis chenopis merged commit 1148f85 into kubernetes:release-1.6 Mar 22, 2017
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this pull request Dec 4, 2023
* added content/es/serverless.md

Signed-off-by: marianogg9 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.