Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID Localization for Task Index and Example. #20261

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

ariscahyadi
Copy link
Contributor

This PR addressing #20111

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2020
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 12, 2020
@netlify
Copy link

netlify bot commented Apr 12, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1047f7e

https://deploy-preview-20261--kubernetes-io-master-staging.netlify.com

@wahyuoi
Copy link
Contributor

wahyuoi commented Apr 12, 2020

/cc
/cc @phanama

Copy link
Contributor

@wahyuoi wahyuoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ariscahyadi, it nicely translated. 🎉 🎉
I've few suggestions that need your comments

content/id/docs/tasks/_index.md Outdated Show resolved Hide resolved
content/id/docs/tasks/_index.md Outdated Show resolved Hide resolved
content/id/docs/tasks/_index.md Outdated Show resolved Hide resolved
content/id/docs/tasks/_index.md Outdated Show resolved Hide resolved
content/id/docs/tasks/_index.md Outdated Show resolved Hide resolved
content/id/docs/tasks/_index.md Outdated Show resolved Hide resolved
content/id/docs/tasks/example-task-template.md Outdated Show resolved Hide resolved
content/id/includes/task-tutorial-prereqs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/example-task-template.md Outdated Show resolved Hide resolved
content/id/docs/tasks/example-task-template.md Outdated Show resolved Hide resolved
content/id/docs/tasks/_index.md Outdated Show resolved Hide resolved
content/id/docs/tasks/_index.md Outdated Show resolved Hide resolved
content/id/docs/tasks/_index.md Outdated Show resolved Hide resolved
content/id/docs/tasks/_index.md Outdated Show resolved Hide resolved
content/id/docs/tasks/_index.md Outdated Show resolved Hide resolved
content/id/docs/tasks/_index.md Outdated Show resolved Hide resolved
Fixed missing page.

Fixed Typos and Capitalization.

Fixing some words.
@girikuncoro
Copy link
Contributor

All the translated pages under Task section cannot be discovered without this main page, thanks for contributing mas @ariscahyadi ! 🎉

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit ae08463 into kubernetes:master Apr 17, 2020
@ariscahyadi
Copy link
Contributor Author

All the translated pages under Task section cannot be discovered without this main page, thanks for contributing mas @ariscahyadi ! 🎉

/lgtm
/approve

You're welcome... thanks for the opportunity @girikuncoro ... hope to contribute more :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants