Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for vSphere CSI Migration #21444

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Add doc for vSphere CSI Migration #21444

merged 1 commit into from
Jul 15, 2020

Conversation

xing-yang
Copy link
Contributor

This PR adds a doc for the vSphere CSI Migration.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jun 3, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit d2c58dc

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f0f1e425bb00c000898cf25

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 3, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 3, 2020
@xing-yang
Copy link
Contributor Author

The following PR that implements this feature needs to get merged first:
kubernetes/kubernetes#90911

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2020
@xing-yang xing-yang mentioned this pull request Jun 3, 2020
Closed
2 tasks
@savitharaghunathan
Copy link
Member

/milestone 1.19

@k8s-ci-robot k8s-ci-robot added this to the 1.19 milestone Jun 3, 2020
sftim
sftim reviewed Jun 3, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Here's some early, informal feedback. I hope it's useful to you.

As this is WIP feel free to skip the suggestions I'm making.

content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
@xing-yang xing-yang changed the title WIP: Add doc for vSphere CSI Migration Add doc for vSphere CSI Migration Jun 22, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2020
@xing-yang
Copy link
Contributor Author

kubernetes/kubernetes#90911 is merged.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2020
@xing-yang
Copy link
Contributor Author

/assign @msau42

@xing-yang
Copy link
Contributor Author

Updated feature state to Beta.

@savitharaghunathan
Copy link
Member

Hi @xing-yang 👋 , Friendly reminder that docs should be reviewed and ready to be merged by July 16th. Thanks!

@xing-yang xing-yang force-pushed the csi_migration_1.19 branch 3 times, most recently from 9a05022 to 3d2486c Compare July 13, 2020 20:28
@kbhawkey
Copy link
Contributor

Page preview:
https://deploy-preview-21444--kubernetes-io-vnext-staging.netlify.app/docs/concepts/storage/volumes/

sftim
sftim reviewed Jul 14, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand the section headed CSI Migration Complete, and I'm worried that other readers might also not be sure on what that means.

Overall, try to keep https://kubernetes.io/docs/concepts/storage/volumes/ as small as it can be. To explain tasks such as the whole set of steps to migrate, I recommend either a page in the Tasks section, or a blog article.

content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2020
@xing-yang
Copy link
Contributor Author

Comments are addressed.

@annajung
Copy link
Contributor

Hi everyone, 👋 1.19 docs shadow here, can we get another quick look as content has changed based on feedback and get a lgtm from both tech/docs?
@msau42 @misterikkit @gnufied @divyenpatel @kbhawkey @sftim

@xing-yang xing-yang force-pushed the csi_migration_1.19 branch 2 times, most recently from 96ed4c6 to d2c58dc Compare July 15, 2020 15:22
@celestehorgan
Copy link
Contributor

from docs

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2020
@savitharaghunathan
Copy link
Member

@msau42 can we get a tech lgtm on this PR? Thanks :)

@msau42
Copy link
Member

msau42 commented Jul 15, 2020

/lgtm

savitharaghunathan
savitharaghunathan reviewed Jul 15, 2020
View reviewed changes
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitharaghunathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 79b9438 into kubernetes:dev-1.19 Jul 15, 2020
@xing-yang
Copy link
Contributor Author

xing-yang commented Aug 9, 2020 •
edited
Loading

Hi @savitharaghunathan, this PR gets merged into dev-1.19 branch, but it is not in the master branch yet:
https://github.com/kubernetes/website/blob/master/content/en/docs/reference/command-line-tools-reference/feature-gates.md

Will this get ported to the master branch automatically or do I need to submit a separate PR to master? Thanks.

@kbhawkey
Copy link
Contributor

kbhawkey commented Aug 9, 2020

Hello @xing-yang . This change will become available on the master branch once v1.19.0 is released.

@xing-yang
Copy link
Contributor Author

Thanks @kbhawkey!

@xing-yang
Copy link
Contributor Author

Hi @kbhawkey, another question: we forgot to add a description of the new feature gate to the doc PR which is merged in dev-1.19. I believe we have passed the deadline to submit anything to dev-1.19? Should I submit a PR to master after 1.19 release?

https://github.com/kubernetes/website/blob/dev-1.19/content/en/docs/reference/command-line-tools-reference/feature-gates.md#list-of-feature-gates-feature-gates

@sftim
Copy link
Contributor

sftim commented Aug 10, 2020

@savitharaghunathan I believe there's no actual deadline for contributions; is that right?

@savitharaghunathan
Copy link
Member

@savitharaghunathan I believe there's no actual deadline for contributions; is that right?

@sftim 👋 It's tricky. This release has so much time between docs final deadline and release. During the usual timelines, my understanding is that everything gets merged into master after release.
However, under given circumstances, I feel all the critical bug fixes related to features in 1.19 should go into dev-1.19. Hope it answers your question :)

@xing-yang
Copy link
Contributor Author

Thanks @savitharaghunathan @sftim! Will submit a PR to dev-1.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@sftim sftim sftim left review comments

@savitharaghunathan savitharaghunathan savitharaghunathan left review comments

@kbhawkey kbhawkey kbhawkey left review comments

@divyenpatel divyenpatel divyenpatel approved these changes

@thockin thockin Awaiting requested review from thockin

Assignees

@celestehorgan celestehorgan

@divyenpatel divyenpatel

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.
10 participants
@xing-yang @k8sio-netlify-preview-bot @savitharaghunathan @divyenpatel @msau42 @kbhawkey @annajung @celestehorgan @k8s-ci-robot @sftim