-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise page about multiple zones #23498
Revise page about multiple zones #23498
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 7196db6 https://deploy-preview-23498--kubernetes-io-master-staging.netlify.app |
If this merges before PR #23466 then that other PR should ideally be revised before merging. |
465a245
to
4c2ebdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add suggestions based on feedback
/label tide/merge-method-squash |
7736683
to
0db4e5a
Compare
/remove-label tide/merge-method-squash |
When you set up your cluster, you might also need to consider whether and how | ||
your setup can restore service if all of the failure zones in a region go | ||
off-line at the same time. For example, do you rely on there being at least | ||
Make sure that any cluster-critical repair work does not rely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sftim. I read through the page again. There are a few places to edit.
Have a look at:
For example, do you rely on there being at least Make sure that any cluster-critical repair work does not rely
When persistent volumes are created, the `PersistentVolumeLabel` | ||
[admission controller](/docs/reference/access-authn-authz/admission-controllers/) | ||
automatically adds zone labels to any PersistentVolumes that are linked to a specific | ||
zone. The {< glossary_tooltip text="scheduler" term_id="kube-scheduler" >}} then ensures, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️ This tooltip is not rendering
## Networking | ||
|
||
Kubernetes itself does not provide zone-aware networking. You can use a | ||
[network plugin](docs/concepts/extend-kubernetes/compute-storage-net/network-plugins/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Kubernetes does not provide ...
The pods should be spread across all 3 zones: | ||
When nodes start up, the kubelet on each node automatically adds | ||
{{< glossary_tooltip text="labels" term_id="label" >}} to the the Node object | ||
that represents that specific kubelet in the Kubernetes API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanup: the the
possible cleanup: s/Node object/Node/
are only placed into the same zone as that volume. | ||
|
||
You can specify a {{< glossary_tooltip text="StorageClass" term_id="storage-class" >}} | ||
for PersistentVolumeClaims that specifies the failure domains (zones) that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit wording/break up sentence. Would this work?
To learn about configuring a StorageClass with failure domains or zones, see Allowed topologies.
find kubernetes/examples/guestbook-go/ -name '*.json' | xargs -I {} kubectl apply -f {} | ||
``` | ||
Kubernetes automatically spreads the Pods for a | ||
workload resources (such as {{< glossary_tooltip text="Deployment" term_id="deployment" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanup: remove a
in for a workload resources
EOF | ||
``` | ||
When you deploy a cluster control plane you can place a replica of each | ||
component in each failure zone that you have used. For example, if you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: simplify:
When you deploy a cluster control plane, place a replica of each
control plane component in each failure zone.
in conjunction with | ||
[Pod topology spread constraints](/docs/concepts/workloads/pods/pod-topology-spread-constraints/) | ||
to control how Pods are spread across your cluster among fault domains. | ||
such as regions, zones, and even specific nodes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the sentences (rebase mixup).
how Pods are spread across your cluster among fault domains. such as regions, zones, and even specific nodes.
{{< glossary_tooltip text="labels" term_id="label" >}} to the the Node object | ||
that represents that specific kubelet in the Kubernetes API. | ||
These labels can include | ||
[zone information](/docs/reference/kubernetes-api/labels-annotations-taints/#topologykubernetesiozone) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Add period at end of sentence
Drop provider-specific details, in line with current content guide. Plus general rewording.
0db4e5a
to
7196db6
Compare
The docs cleanup looks good. |
LGTM label has been added. Git tree hash: 8296e8400701a26d1f5e873ef39c4e8769f26f55
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irvifa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Revise https://kubernetes.io/docs/setup/best-practices/multiple-zones/ [preview]:
Fixes #14964
Fixes #23982