Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating doc for setHostnameAsFQDN feature to beta in v1.20 #24350

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Updating doc for setHostnameAsFQDN feature to beta in v1.20 #24350

merged 1 commit into from
Oct 20, 2020

Conversation

javidiaz
Copy link
Contributor

@javidiaz javidiaz commented Oct 2, 2020

Feature SetHostnameAsFQDN is being graduated to Beta and its feature gate will be enabled by default. The corresponding KEP is already merged kubernetes/enhancements#1797. The actual code change is tracked in kubernetes/kubernetes#95267

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 2, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit c29185d

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f8ec75a9795dc0009a65a56

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 2, 2020
@javidiaz javidiaz mentioned this pull request Oct 2, 2020
Closed
@kikisdeliveryservice
Copy link
Member

cc: @annajung this is for kubernetes/enhancements#1797

@annajung
Copy link
Contributor

annajung commented Oct 2, 2020

/sig node
/assign @annajung
/milestone 1.20

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Oct 2, 2020
sftim
sftim previously requested changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @javidiaz

I can see one tweak that you'll need to make.

content/en/docs/reference/command-line-tools-reference/feature-gates.md Show resolved Hide resolved
@javidiaz javidiaz requested a review from sftim October 3, 2020 23:43
@sftim
Copy link
Contributor

sftim commented Oct 5, 2020

/hold
pending kubernetes/kubernetes#95267 landing in the v1.20 release

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2020
@sftim sftim dismissed their stale review October 5, 2020 14:46

Superseded

sftim
sftim reviewed Oct 5, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown changes LGTM

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2020
thockin
thockin reviewed Oct 19, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 19aa65f86be7802fc5448ee1b5497f6885708ea6

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/es Issues or PRs related to Spanish language and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 19, 2020
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language labels Oct 19, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 20, 2020
@javidiaz
Copy link
Contributor Author

Hi @thockin could you please approve again? Sorry, I needed to rebase.

@javidiaz
Copy link
Contributor Author

I messed up previous push and lots of tags got added. Trying to clean up.

/remove-area blog
/remove-language fr
/remove-language id
/remove-language it
/remove-language ja
/remove-language ko
/remove-language ru
/remove-language zh

@k8s-ci-robot k8s-ci-robot removed area/blog Issues or PRs related to the Kubernetes Blog subproject language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language labels Oct 20, 2020
@javidiaz
Copy link
Contributor Author

/remove-language es

@k8s-ci-robot k8s-ci-robot removed the language/es Issues or PRs related to Spanish language label Oct 20, 2020
@javidiaz
Copy link
Contributor Author

hi @sftim kubernetes/kubernetes#95267 got merged, can we remove hold from here? Thanks!

@sftim
Copy link
Contributor

sftim commented Oct 20, 2020

Sure
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2020
@thockin
Copy link
Member

thockin commented Oct 20, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: efd4ec7851d9ef7ee2c3365df54596eeda56d9de

@annajung
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung, javidiaz, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit c06d366 into kubernetes:dev-1.20 Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@thockin thockin thockin left review comments

@zparnold zparnold Awaiting requested review from zparnold

Assignees

@thockin thockin

@annajung annajung

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.
7 participants
@javidiaz @k8sio-netlify-preview-bot @kikisdeliveryservice @annajung @sftim @k8s-ci-robot @thockin