Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuntimeClass GA #24698

Merged
merged 6 commits into from
Nov 12, 2020
Merged

RuntimeClass GA #24698

merged 6 commits into from
Nov 12, 2020

Conversation

SergeyKanzhelev
Copy link
Member

Also fixed the version of PodOverhead feature flag

/sig node
/hold

Hold as waiting on k/k PR to be merged.

KEP: kubernetes/enhancements#585
k/k: kubernetes/kubernetes#95718

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 23, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 21362d8

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f9b5d24ad1e5b0007532edd

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Oct 23, 2020
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Oct 23, 2020
Closed
@reylejano
Copy link
Member

/milestone 1.20

@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Oct 23, 2020
@reylejano
Copy link
Member

/cc @annajung

@SergeyKanzhelev
Copy link
Member Author

/assign @tallclair

sftim
sftim previously requested changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature state specified here isn't valid; that's the only thing to fix that I can see.

content/en/docs/concepts/containers/runtime-class.md Outdated Show resolved Hide resolved
@sftim sftim dismissed their stale review October 26, 2020 22:39

Superseded

sftim
sftim reviewed Oct 30, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gap in my knowledge is how Kubernetes behaves when a stable API such as Pod references an unstable feature such as PodOverhead.

I've guessed at an approach; if the behavior I'm describing matches my guess, then this is how I'd document it.

content/en/docs/concepts/containers/runtime-class.md Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/admission-controllers.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/admission-controllers.md Outdated Show resolved Hide resolved
@tallclair
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 383f429628c8fada7d483dd91dd1b6f42fe2546c

irvifa
irvifa reviewed Nov 4, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020
@annajung
Copy link
Contributor

annajung commented Nov 5, 2020

/assign @reylejano-rxm

@irvifa
Copy link
Member

irvifa commented Nov 10, 2020

/sig node

@irvifa
Copy link
Member

irvifa commented Nov 10, 2020

/assign @tallclair

@SergeyKanzhelev
Copy link
Member Author

@irvifa there is already lgtm from @tallclair: #24698 (comment)

@SergeyKanzhelev
Copy link
Member Author

PR is on hold to have k/k PR merged first

irvifa
irvifa reviewed Nov 12, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2054614 into kubernetes:dev-1.20 Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallclair tallclair tallclair left review comments

@sftim sftim sftim left review comments

@irvifa irvifa irvifa left review comments

@tengqm tengqm tengqm left review comments

@kbhawkey kbhawkey kbhawkey left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@egernst egernst Awaiting requested review from egernst

@annajung annajung Awaiting requested review from annajung

Assignees

@tallclair tallclair

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.
10 participants
@SergeyKanzhelev @k8sio-netlify-preview-bot @reylejano @tallclair @k8s-ci-robot @annajung @irvifa @kbhawkey @tengqm @sftim