Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for snapshot GA #24849

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Add doc for snapshot GA #24849

merged 1 commit into from
Nov 13, 2020

Conversation

xing-yang
Copy link
Contributor

This PR adds doc for bringing volume snapshot feature to GA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 2, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 2, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit e798834

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5fae0228f50ec0000744e19b

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Nov 2, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 2, 2020
@xing-yang xing-yang mentioned this pull request Nov 2, 2020
Closed
@xing-yang
Copy link
Contributor Author

/assign @msau42

@annajung
Copy link
Contributor

annajung commented Nov 2, 2020

/milestone 1.20
/sig storage
/hold pending merge kubernetes/kubernetes#95282
/cc @eagleusb

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Nov 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Nov 2, 2020
sftim
sftim requested changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I spotted one error and also would like to see the page about PVs reworded to explain the context for snapshotting a little better.

content/en/docs/concepts/storage/persistent-volumes.md Outdated
@@ -723,13 +723,8 @@ Only statically provisioned volumes are supported for alpha release. Administrat

## Volume Snapshot and Restore Volume from Snapshot Support

{{< feature-state for_k8s_version="v1.17" state="beta" >}}

Volume snapshot feature was added to support CSI Volume Plugins only. For details, see [volume snapshots](/docs/concepts/storage/volume-snapshots/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see this sentence revised to suit the now-stable feature.

Copy link
Contributor Author

@xing-yang xing-yang Nov 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about Volume snapshot feature is graduated in the 1.20 release. It only supports out-of-tree CSI Volume Plugins as in-tree Volume Plugins are deprecated. See the doc [here](https://github.com/kubernetes/community/blob/master/sig-storage/volume-plugin-faq.md) for more information on deprecated volume plugins.?

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
@annajung
Copy link
Contributor

annajung commented Nov 5, 2020

/assign @eagleusb

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2020
@irvifa
Copy link
Member

irvifa commented Nov 8, 2020

/cc @thockin

@annajung
Copy link
Contributor

/hold cancel
k/k pr merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2020
@annajung
Copy link
Contributor

hi @msau42 @kubernetes/sig-storage-pr-reviews can you provide a tech review / lgtm?

@jimangel
Copy link
Member

Agree with @kbhawkey's feedback, once addressed LGTM - thanks!

@xing-yang
Copy link
Contributor Author

Comments are addressed. Thanks.

@irvifa
Copy link
Member

irvifa commented Nov 13, 2020

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 13, 2020
irvifa
irvifa reviewed Nov 13, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f8417dd681f9a7c48f21f5aa9713dfd1674d59a0

irvifa
irvifa reviewed Nov 13, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit e62b6e1 into kubernetes:dev-1.20 Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@irvifa irvifa irvifa left review comments

@tengqm tengqm tengqm left review comments

@kbhawkey kbhawkey kbhawkey left review comments

@sftim sftim sftim requested changes

@saad-ali saad-ali Awaiting requested review from saad-ali

@eagleusb eagleusb Awaiting requested review from eagleusb

@thockin thockin Awaiting requested review from thockin

Assignees

@irvifa irvifa

@eagleusb eagleusb

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.