Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add metric and flag information for BoundServiceAccountTokenVolume #24854

Merged
merged 1 commit into from
Dec 7, 2020
Merged

add metric and flag information for BoundServiceAccountTokenVolume #24854

merged 1 commit into from
Dec 7, 2020

Conversation

zshihang
Copy link
Contributor

@zshihang zshihang commented Nov 2, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 2, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 2, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 20e4796

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5fa07d705bb90e00083450c7

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Nov 2, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 2, 2020
@zshihang zshihang mentioned this pull request Nov 2, 2020
Merged
@zshihang
Copy link
Contributor Author

zshihang commented Nov 2, 2020

exception issue is opened here: kubernetes/enhancements#2126

@annajung
Copy link
Contributor

annajung commented Nov 2, 2020

/milestone 1.20
/hold for exception request approval

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Nov 2, 2020
@liggitt liggitt mentioned this pull request Nov 2, 2020
Closed
tengqm
tengqm reviewed Nov 3, 2020
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
@@ -55,7 +55,7 @@ different Kubernetes components.
| `APIResponseCompression` | `false` | Alpha | 1.7 | |
| `AppArmor` | `true` | Beta | 1.4 | |
| `BalanceAttachedNodeVolumes` | `false` | Alpha | 1.11 | |
| `BoundServiceAccountTokenVolume` | `false` | Alpha | 1.13 | |
| `BoundServiceAccountTokenVolume` | `true` | Beta | 1.20 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of replacing the existing line, we should add a new line so the result would be:

| `BoundServiceAccountTokenVolume` | `false` | Alpha | 1.13 | 1.19 |
| `BoundServiceAccountTokenVolume` | `true` | Beta | 1.20 |  |

@annajung
Copy link
Contributor

annajung commented Nov 3, 2020

/hold cancel
exception approved, k/k pr merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2020
@liggitt
Copy link
Member

liggitt commented Nov 3, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2020
@liggitt
Copy link
Member

liggitt commented Nov 3, 2020

will unhold once KEP updates are made

@liggitt liggitt mentioned this pull request Nov 4, 2020
Closed
@liggitt
Copy link
Member

liggitt commented Nov 4, 2020

beta graduation is moved to 1.21 per discussion in kubernetes/kubernetes#95667 (comment), but I would still like to add the metric and extended expiration description information (that can be done in the master branch of the website since it is applicable to releases prior to 1.20 as well

@zshihang zshihang mentioned this pull request Nov 5, 2020
Merged
@annajung
Copy link
Contributor

annajung commented Nov 5, 2020

/milestone clear
enhancement deferred to 1.21 (#24854 (comment))
There isn't 1.21 milestone yet, I'm not sure what the protocol is here.
Do we close out the PR or leave it open? @sftim @jimangel @savitharaghunathan

@k8s-ci-robot k8s-ci-robot removed this from the 1.20 milestone Nov 5, 2020
@zshihang
Copy link
Contributor Author

zshihang commented Nov 5, 2020

i think we still want add some documentation around metrics and extended expiration.

the PR is submitted.
kubernetes/kubernetes#96273

@annajung
Copy link
Contributor

annajung commented Nov 5, 2020

Then, I think this one could be to master branch since it's not being tracked with 1.20 release? what do you think?

@annajung
Copy link
Contributor

annajung commented Nov 5, 2020

Can you also retitle title this as well?

@annajung
Copy link
Contributor

hi @zshihang can you update us on what your plan is for this PR?
I'm not clear on if this needs to be tracked as part of 1.20 or will be made against master instead.
Please let me know so it can be tracked accordingly! thank you

@zshihang
Copy link
Contributor Author

i am fine move it to master. this PR will basically add information about metric and flags.

@zshihang zshihang changed the title BoundServiceAccountTokenVolume is Beta now add metric and flag information for BoundServiceAccountTokenVolume Nov 20, 2020
@zshihang zshihang changed the base branch from dev-1.20 to master November 20, 2020 22:59
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 20, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2020
@netlify
Copy link

netlify bot commented Nov 20, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ade3577

https://deploy-preview-24854--kubernetes-io-master-staging.netlify.app

@annajung
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fbf7c9f799a6c28970b9bbd9e4efeb9c975c6702

@annajung
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2020
@sftim
Copy link
Contributor

sftim commented Dec 4, 2020

@kubernetes/sig-auth-pr-reviews I'd also like a technical LGTM here; is that OK?

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Dec 4, 2020
@liggitt
Copy link
Member

liggitt commented Dec 7, 2020

/lgtm
/approve

@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 7, 2020

Page preview:
https://deploy-preview-24854--kubernetes-io-master-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/#feature-gates

@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 7, 2020

/lgtm

@annajung
Copy link
Contributor

annajung commented Dec 7, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0f966a7 into kubernetes:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees

@liggitt liggitt

@kbhawkey kbhawkey

@annajung annajung

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zshihang @k8sio-netlify-preview-bot @annajung @liggitt @k8s-ci-robot @sftim @kbhawkey @tengqm