Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the support of mixed protocol values in the LoadBalancer type of Services #24874

Merged
merged 3 commits into from
Nov 18, 2020
Merged

Document the support of mixed protocol values in the LoadBalancer type of Services #24874

merged 3 commits into from
Nov 18, 2020

Conversation

janosi
Copy link
Contributor

@janosi janosi commented Nov 3, 2020

This PR is to document the support of mixed protocol values in the LoadBalancer type of Services

This is for the kubernetes/enhancement: kubernetes/enhancements#1435
kubernetes/kubernetes PR: kubernetes/kubernetes#94028

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 3, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit c640aee

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5fb4295599c0e600085b179b

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 3, 2020
@janosi janosi mentioned this pull request Nov 3, 2020
Closed
@annajung
Copy link
Contributor

annajung commented Nov 3, 2020

/milestone 1.20
/sig network
/cc @kcmartin
/hold pending merge kubernetes/kubernetes#94028

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Nov 3, 2020
@kcmartin
Copy link
Contributor

kcmartin commented Nov 3, 2020

@janosi -- would you please add your feature to the Feature Gates list, here:
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

@annajung
Copy link
Contributor

annajung commented Nov 5, 2020

/assign @kcmartin

@kcmartin
Copy link
Contributor

Hi @janosi :

Friendly reminder that you'll need to add your feature to the Feature gates list:
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

@janosi
Copy link
Contributor Author

janosi commented Nov 14, 2020

Hello @annajung @kcmartin The k/k PR has been merged. I updated this PR with the requested change on the feature gate list.

annajung
annajung reviewed Nov 16, 2020
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md
@@ -125,6 +125,7 @@ different Kubernetes components.
| `LocalStorageCapacityIsolation` | `false` | Alpha | 1.7 | 1.9 |
| `LocalStorageCapacityIsolation` | `true` | Beta | 1.10 | |
| `LocalStorageCapacityIsolationFSQuotaMonitoring` | `false` | Alpha | 1.15 | |
| `MixedProtocolLBService` | `false` | Alpha | 1.20 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a short description below the table on what behavior this provides?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I added a description right now.

@annajung
Copy link
Contributor

/hold cancel
k/k pr merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2020
@annajung
Copy link
Contributor

Page preview https://5fb4295599c0e600085b179b--kubernetes-io-vnext-staging.netlify.app/docs/concepts/services-networking/service/#load-balancers-with-mixed-protocol-types

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c4c52225b467ba30fb248623d752ad2d0f8d4f94

@annajung
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2faaed6 into kubernetes:dev-1.20 Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annajung annajung annajung left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@zparnold zparnold Awaiting requested review from zparnold

@kcmartin kcmartin Awaiting requested review from kcmartin

Assignees

@kcmartin kcmartin

@annajung annajung

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.
5 participants
@janosi @k8sio-netlify-preview-bot @annajung @kcmartin @k8s-ci-robot