Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote ConfigurableFSGroupPolicy feature to beta #24913

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Promote ConfigurableFSGroupPolicy feature to beta #24913

merged 1 commit into from
Nov 12, 2020

Conversation

mattcary
Copy link
Contributor

@mattcary mattcary commented Nov 5, 2020 •
edited
Loading

KEP at kubernetes/enhancements#695

The KEP feature is currently alpha. In 1.20 we are updating it to beta and will be changing the documentation accordingly.

PRs (not exhaustive)
kubernetes/kubernetes#95866
kubernetes/kubernetes#95739
kubernetes/kubernetes#96247

/milestone 1.20

@k8s-ci-robot
Copy link
Contributor

@mattcary: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

KEP at kubernetes/enhancements#695

The KEP feature is currently alpha. In 1.20 we are updating it to beta and will be changing the documentation accordingly.

/milestone 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 5, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit c5ffbec

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5fa9b16742e9870007e09127

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 5, 2020
@mattcary
Copy link
Contributor Author

mattcary commented Nov 5, 2020

/assign @gnufied

@sftim sftim marked this pull request as draft November 5, 2020 20:31
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2020
@sftim
Copy link
Contributor

sftim commented Nov 5, 2020

/milestone 1.20

@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Nov 5, 2020
@annajung
Copy link
Contributor

annajung commented Nov 5, 2020

/assign @eagleusb
/hold no k/k pr
/sig storage

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Nov 5, 2020
sftim
sftim reviewed Nov 5, 2020
View reviewed changes
content/en/docs/tasks/configure-pod-container/security-context.md
@@ -149,7 +149,7 @@ exit

## Configure volume permission and ownership change policy for Pods

{{< feature-state for_k8s_version="v1.18" state="alpha" >}}
{{< feature-state for_k8s_version="v1.20" state="beta" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

@mattcary
Copy link
Contributor Author

mattcary commented Nov 5, 2020

I've updated the description with some PRs that are for the beta effort.

@irvifa
Copy link
Member

irvifa commented Nov 8, 2020

The two of the k/k PRs is still opened, does the exception accepted for this?

@mattcary
Copy link
Contributor Author

mattcary commented Nov 9, 2020

The two of the k/k PRs is still opened, does the exception accepted for this?

These should be closed before the code freeze on 12 Nov.

@gnufied
Copy link
Member

gnufied commented Nov 9, 2020

Yeah I don't think any exception should be necessary.

sftim
sftim previously requested changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW we leave in the history of what versions the feature was alpha in.

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
Comment on lines 84 to 85
| `ConfigurableFSGroupPolicy` | `false` | Alpha | 1.18 | |
| `ConfigurableFSGroupPolicy` | `true` | Beta | 1.20 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `ConfigurableFSGroupPolicy` | `false` | Alpha | 1.18 | |
| `ConfigurableFSGroupPolicy` | `true` | Beta | 1.20 | |
| `ConfigurableFSGroupPolicy` | `false` | Alpha | 1.18 | 1.19 |
| `ConfigurableFSGroupPolicy` | `true` | Beta | 1.20 | |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks.

@sftim
Copy link
Contributor

sftim commented Nov 10, 2020

Hi @mattcary

Are there any behavior changes other than graduation to beta? If not, this looks like it could be marked as ready for review.

@gnufied
Copy link
Member

gnufied commented Nov 10, 2020

@sftim the feature is moving to beta without any change in behaviour.

@mattcary mattcary marked this pull request as ready for review November 10, 2020 19:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2020
@mattcary
Copy link
Contributor Author

Thanks all. I've marked this ready for review.

@sftim sftim dismissed their stale review November 11, 2020 08:21

Superseded

@sftim
Copy link
Contributor

sftim commented Nov 11, 2020

/retitle Promote ConfigurableFSGroupPolicy feature to beta

@k8s-ci-robot k8s-ci-robot changed the title Placeholder CL for fsgroup policy beta Promote ConfigurableFSGroupPolicy feature to beta Nov 11, 2020
@irvifa
Copy link
Member

irvifa commented Nov 11, 2020

Remaining open PR is kubernetes/kubernetes#95739

@annajung
Copy link
Contributor

/hold cancel
all k/k prs merged

/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 52bdff4813fc3210fe725069111c337c20dec64a

@annajung
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3450e8b into kubernetes:dev-1.20 Nov 12, 2020
@mattcary mattcary deleted the placerholder-fsgroup branch June 3, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@thockin thockin Awaiting requested review from thockin

Assignees

@gnufied gnufied

@eagleusb eagleusb

@annajung annajung

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.
8 participants
@mattcary @k8s-ci-robot @k8sio-netlify-preview-bot @sftim @annajung @irvifa @gnufied @eagleusb