Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim whitespaces in manifests #25344

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Trim whitespaces in manifests #25344

merged 1 commit into from
Dec 15, 2020

Conversation

makocchi-git
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Dec 2, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Dec 2, 2020
@netlify
Copy link

netlify bot commented Dec 2, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 28c964b

https://deploy-preview-25344--kubernetes-io-master-staging.netlify.app

@makocchi-git
Copy link
Contributor Author

preview is here
original

sftim
sftim reviewed Dec 2, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cb6320330b8084d1fd98d9484f76d9184dba0566

@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 5, 2020

Thanks @makocchi-git
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 5, 2020
@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 7, 2020 •
edited
Loading

👋 @makocchi-git Since there is a hold until the release is out, would you rebase your changes to a single commit?

@makocchi-git
Copy link
Contributor Author

@kbhawkey (cc @sftim)
Thank you for your comments. I squashed.

@kbhawkey
Copy link
Contributor

/lgtm

@kbhawkey
Copy link
Contributor

Trying this again,
/remove-label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 15, 2020
@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit bdc79d9 into kubernetes:master Dec 15, 2020
@makocchi-git makocchi-git deleted the fix/trim_space_psp branch December 16, 2020 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@pweil- pweil- Awaiting requested review from pweil-

@steveperry-53 steveperry-53 Awaiting requested review from steveperry-53

Assignees

@kbhawkey kbhawkey

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@makocchi-git @k8s-ci-robot @kbhawkey @sftim